Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monthly Dropdown should not be available in Panel until Monthly donation is made. #2823

Closed
ryanml opened this issue Jan 5, 2019 · 1 comment · Fixed by brave/brave-core#2069
Assignees
Labels

Comments

@ryanml
Copy link
Contributor

ryanml commented Jan 5, 2019

Description

The dropdown to select a recurring contribution in the Rewards Panel should not be visible until a user has made an ad-hoc donation, selecting "Make this Monthly" for that publisher.

Test plan:

  1. Start Brave, enable Rewards.
  2. Go to a verified publisher's site.
  3. Open the Rewards Panel, ensure that no dropdown is available.
  4. Send them a recurring tip.
  5. Re-open the panel and confirm the dropdown is present with the current recurring amount.
  6. Change the donation amount via the panel to 0.0
  7. Confirm the dropdown is no longer available.
@ryanml ryanml added feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 5, 2019
@ryanml ryanml self-assigned this Jan 5, 2019
@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 6, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@ryanml ryanml added this to the 0.64.x - Nightly milestone Mar 19, 2019
NejcZdovc pushed a commit to ryanml/brave-core that referenced this issue Mar 25, 2019
Fixes brave/brave-browser#2823

Monthly donation functionality via panel
ryanml added a commit to brave/brave-core that referenced this issue Mar 28, 2019
Fixes brave/brave-browser#2823

Monthly donation functionality via panel
ryanml added a commit to brave/brave-core that referenced this issue Apr 2, 2019
Fixes brave/brave-browser#2823

Monthly donation functionality via panel
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Apr 8, 2019
Fixes brave/brave-browser#2823

Monthly donation functionality via panel
@ryanml ryanml added the QA/Yes label Apr 8, 2019
pilgrim-brave pushed a commit to brave/brave-core that referenced this issue Apr 16, 2019
Fixes brave/brave-browser#2823

Monthly donation functionality via panel
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 15, 2019

Verification passed on

Brave 0.65.93 Chromium: 74.0.3729.131 (Official Build) beta (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

Verification passed on

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Ubuntu 18.04 LTS

Verified passed with

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment