Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAT is sometimes truncated on panel for 'Tip this site monthly' value #4503

Closed
LaurenWags opened this issue May 20, 2019 · 3 comments · Fixed by brave/brave-ui#489 or brave/brave-core#2590

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #2823

Some values of BAT for monthly drop down on panel do not display properly. eg - if you choose 20 or 50 BAT, the 'T' in BAT is cut off. Other values like 5, 10, 100 display properly. Display issue for 1 BAT logged under #4502.

Steps to Reproduce

  1. Clean install
  2. Enable Rewards and fund wallet
  3. Visit verified publisher site (on staging, I used kjozwiakstaging.github.io)
  4. Set monthly recurring tip.
  5. Open panel and if you did not already select 20 or 50, change to one of those.

Actual result:

T is cut off.
Screen Shot 2019-05-20 at 1 17 29 PM

Screen Shot 2019-05-20 at 1 17 40 PM

Expected result:

T should not be cut off.

Screen Shot 2019-05-20 at 1 17 52 PM

Screen Shot 2019-05-20 at 1 18 10 PM

Screen Shot 2019-05-20 at 1 18 20 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? unsure but probably yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @brave/legacy_qa

@NejcZdovc
Copy link
Contributor

reopening since UI PR closed it. @cg505 please don't add closing tags to UI PR's, only on brave-core PR's.

cc @ryanml

@cg505
Copy link

cg505 commented Jun 9, 2019

Sorry about that, will do in the future.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 2, 2019

Verification passed on

Brave 0.68.115 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 10 OS Version 1803 (Build 17134.523)

image

image

image

Verified passed with

Brave 0.68.116 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Screen Shot 2019-08-02 at 1 04 04 PM

Screen Shot 2019-08-02 at 1 04 21 PM

Verification passed on

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment