Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFT pinning optimisation #29230

Closed
cypt4 opened this issue Mar 22, 2023 · 2 comments · Fixed by brave/brave-core#17742
Closed

NFT pinning optimisation #29230

cypt4 opened this issue Mar 22, 2023 · 2 comments · Fixed by brave/brave-core#17742
Assignees
@cypt4
Labels
feature/web3/ipfs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.51.x - Release

Comments

@cypt4
Copy link

cypt4 commented Mar 22, 2023

Currently we pin root CID for metadata and url which may include unnecessary data.
For example pinning of ipfs://bafy/1.png leads to pinning of ipfs://bafy1.
We should pin exact file recursively and path to the file non-recursively.
@cypt4 cypt4 self-assigned this Mar 22, 2023
@cypt4 cypt4 added QA/Yes release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 22, 2023
@cypt4 cypt4 mentioned this issue Mar 23, 2023
Merged
25 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Mar 27, 2023
@cypt4
NFT pinning optimisation
7a2009f 
Resolves brave/brave-browser#29230
cypt4 added a commit to brave/brave-core that referenced this issue Mar 29, 2023
@cypt4
NFT pinning optimisation (#17742)
b584830 
* NFT pinning optimisation
Resolves brave/brave-browser#29230
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Mar 29, 2023
@brave-builds brave-builds mentioned this issue Mar 31, 2023
Merged
7 tasks
@cypt4 cypt4 mentioned this issue Apr 4, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Apr 5, 2023

The above requires 1.51.79 or higher for 1.51.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Apr 10, 2023 •
edited
Loading

Verification passed on

Brave 1.51.80 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Linux
  • Verified steps from brave/brave-core#17742
  • Verified NFT folder metadata is pinned directly
  • Verified NFT metadata is pinned recursively
29230.mp4

Verification passed on

Brave 1.51.80 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#17742
  • Verified NFT folder metadata is pinned directly
  • Verified NFT metadata is pinned recursively
29230.mp4

Verification passed on

Brave 1.51.80 Chromium: 112.0.5615.49 (Official Build) beta (arm64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#17742
  • Verified NFT folder metadata is pinned directly
  • Verified NFT metadata is pinned recursively
29230.mov

@srirambv srirambv mentioned this issue Apr 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/web3/ipfs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

NFT pinning optimisation brave/brave-core
4 participants
@kjozwiak @srirambv @brave-builds @cypt4