NFT pinning optimisation #17742
Merged
NFT pinning optimisation #17742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypt4
force-pushed
the
brave_29230
branch
2 times, most recently
from
ea7d520
to
04f3b75
Compare
Comment on lines
26
to
28
| bool PinData::operator==(const PinData& d) { | ||
| return this->cid == d.cid && this->pinning_mode == d.pinning_mode; | ||
| } |
There was a problem hiding this comment.
Why we need non-const version?
| } | ||
|
|
||
| absl::optional<std::vector<ipfs::PinData>> | ||
| IpfsLocalPinService::ExtractMergedPinData(std::vector<std::string> ipfs_urls) { |
| return absl::nullopt; | ||
| } | ||
| for (const auto& item : pins_data_for_url.value()) { | ||
| if (std::find(result.begin(), result.end(), item) == result.end()) { |
| builder += part; | ||
| result.push_back(PinData{builder, PinningMode::DIRECT}); | ||
| } | ||
| result[result.size() - 1].pinning_mode = PinningMode::RECURSIVE; |
supermassive
approved these changes
Mar 24, 2023
|
/build android |
|
Verification passed on
17742.mp4 |
kjozwiak
pushed a commit
that referenced
this pull request
Apr 5, 2023
Uplift of #17742 (squashed) to beta
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#29230
Before: ipfs://bafy/1/1.png is given and ipfs://bafy is pinned recursively.
After: bafy and bafy/1 pinned non-recursively and bafy/1/1.png pinned recursively.
Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
http://127.0.0.1:45001/api/v0/pin/ls?arg=%2Fipfs%2F%2F