Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63. #30025

Closed
mkarolin opened this issue Apr 26, 2023 · 8 comments · Fixed by brave/brave-core#18271
Closed

Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63. #30025

mkarolin opened this issue Apr 26, 2023 · 8 comments · Fixed by brave/brave-core#18271

Comments

@mkarolin
Copy link
Contributor

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/113.0.5672.53..113.0.5672.63?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@kjozwiak
Copy link
Member

Closing as brave/brave-core#18270 & brave/brave-core#18269 were merged into 1.52.x & 1.51.x.

@kjozwiak
Copy link
Member

The above requires 1.51.107 or higher for 1.51.x verification 👍

@kjozwiak
Copy link
Member

Quick overview of the work remaining re: affected areas due to C113 on the following platforms:

Platforms that require a spot check due to already completing full check of the affected areas mentioned via #28979 (comment).

Platforms that still need to check/verify the affected areas due to C113 changes as per #28979 (comment).

  • macOS - Still needs to check affected areas

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.51.107 Chromium: 113.0.5672.63 (Official Build) (64-bit)
-- | --
Revision | 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS | Windows 10 Version 21H2 (Build 19044.2846)

image

@LaurenWags LaurenWags added QA/Test-All-Platforms QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 28, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Apr 28, 2023

Verified with

Brave | 1.51.107 Chromium: 113.0.5672.63 (Official Build) (x86_64)
-- | --
Revision | 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS | macOS Version 13.3.1 (Build 22E261)

Verified the "Desktop affected areas" listed under #28979 (comment) as per #30025 (comment).

Copying clean link in the sharing hub - PASSED
  1. Confirmed "Copy clean link" is displayed in the share menu from URL bar
  2. Confirm that Copy clean link is NOT shown for brave internal pages
  3. While URL is highlighted, opened "Edit" from macOS app menu and confirmed "Copy clean link" does NOT have Cmd + C as the shortcut, regular "Copy" has this shortcut. (note, this is macOS specific as per Disable Copy Clean link hotkeys for OSX #29303)
  4. Used "Cmd + C" while the URL bar is in focus to copy the URL
  5. Opened a new tab and pasted the copied URL
  6. Confirmed link pasted correctly
  7. Confirmed that "Copy clean link" is displayed in the share menu from URL bar even when the flags #brave-copy-clean-link-by-default is disabled via brave://flags
  8. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
  9. Used the "Copy clean link" option from context menu
  10. Opened a new tab and pasted the copied URL
  11. Confirmed link pasted correctly
step 1 step 2 step 3 step 5 step 7 step 8 step 10
1 2 3 5 7 8 10
Tabs are styled correctly - PASSED
  • Confirmed that Tab hover modes works as expected
Card Card with Preview Tooltip
1 2 3
Vertical tabs on Windows (layout and general functionality) - PASSED (see note)

#28979 (comment) specifies vertical tabs check on Windows, so just did basic functionality check of vertical tabs on macOS:

  • Confirmed able to enable the brave://flags/#brave-vertical-tabs flag
  • Confirmed "Use Vertical Tabs" showed in tab context menu
  • Confirmed able to switch between vertical and horizontal tabs
  • Confirmed able to re-order vertical tabs
  • Confirmed able to tear off a vertical tab
  • Confirmed able to re-attach a vertical tab to a window
Example Example Example Example
Screenshot 2023-04-28 at 2 54 37 PM Screenshot 2023-04-28 at 2 54 45 PM Screenshot 2023-04-28 at 2 55 09 PM Screenshot 2023-04-28 at 2 59 25 PM
Settings webui (fonts look correct, general functionality) - PASSED

Generally confirmed look and feel of brave://settings pages were as expected.
Confirmed able to navigate into various sub sections/page.
Spot checked various settings for functionality.

Brave version in settings webui looks correct - PASSED
  • Confirmed that Brave version is shown correctly in brave://settings, brave://settings/help and brave://version
brave://settings brave://settings/help brave://version
1 2 3
Sync works correctly - PASSED
  • Performed the general sync testing on 1.51.x and ensured that sync works as expected
  • Synced 1.51.x with 2 macOS laptops and 1 Android device
  • Ensured that bookmarks, passwords and tabs from all the devices are synced
  • Ensured removing one device from the sync chain removes the device from all the devices
  • Ensured removing a bookmark from one device, removes the bookmark from all the synced devices

1.51.x

Screenshot 2023-04-28 at 4 05 47 PM
Side panel button works and has correct tooltips - PASSED
  • Confirmed that sidebar is not shown by default in the release channel
  • Confirmed sidebar can be enabled on release channel
  • Confirmed that Reading list icon is added to the sidebar menu
  • Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
  • Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
  • Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
  • Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
  • Confirmed that reading list icon is shown in the URL bar, next to wallet icon
  • Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
  • Confirmed that sites can be segregated to Read and Unread list
  • Confirmed that sites can be deleted from the reading list
  • Confirmed that tooltip is shown correctly for each menu item in sidebar

Sidebar Tooltips

Brave talk wallet Bookmarks Reading list Add to sidebar + Show settings website tool tip
1 2 3 4 5 6 7

@btlechowski
Copy link

Verification passed on

Brave 1.51.107 Chromium: 113.0.5672.63 (Official Build) (64-bit)
Revision 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS Ubuntu 18.04 LTS

image

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 28, 2023
@kjozwiak
Copy link
Member

kjozwiak commented May 1, 2023

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.51.107 Chromium: 113.0.5672.63 (Official Build) (32-bit)
--- | ---
Revision | 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS | Android 13; Build/UPB1.230309.014; 33; UpsideDownCake
Example Example
Screenshot_20230501-013429 Screenshot_20230501-013435

Verification PASSED on Samsung Galaxy Tab S8 Ultra running Android 13 using the following build(s):

Brave | 1.51.107 Chromium: 113.0.5672.63 (Official Build) (32-bit)
--- | ---
Revision | 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS | Android 13; Build/TP1A.220624.014; 33; REL
Example Example
Screenshot_20230501_013630_Brave Screenshot_20230501_013636_Brave

@kjozwiak
Copy link
Member

kjozwiak commented May 3, 2023

Labelling as QA/No and release-notes/exclude in favour of #30096.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment