Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63. #18271

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63. #18271

merged 4 commits into from
Apr 28, 2023

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#30025

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Apr 27, 2023
@mkarolin mkarolin requested review from a team as code owners April 27, 2023 01:26
@mkarolin mkarolin self-assigned this Apr 27, 2023
@mkarolin
Temporarily disables WindowClosingConfirmBrowserTest.TestWithDownload…
3c2e47b 
… on MacOS.

The test fails because in Chromium Private/Incognito profiles now ignore the
"Ask for download location" setting and always prompt for the location.
We will fix that in brave/brave-browser#29823,
but until then let's disable this test on MacOS.
This was referenced Apr 28, 2023
Merged
Merged
@mkarolin
Copy link
Collaborator Author

Uplifts have been merged, merging to master.

@mkarolin mkarolin merged commit 4a88087 into master Apr 28, 2023
@mkarolin mkarolin deleted the 113.0.5672.63_master branch April 28, 2023 16:05
@github-actions github-actions bot added this to the 1.53.x - Nightly milestone Apr 28, 2023
@mkarolin mkarolin mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mkarolin mkarolin

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Milestone
1.56.x - Release
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 113.0.5672.53 to Chromium 113.0.5672.63.
2 participants
@mkarolin @brave-builds