Incorrect response for the metrics Brave.Today.IsEnabled when brave news is turned OFF and ON via different NTP's

[GeetaSarvadnya]

Description

Found while testing #30154
Incorrect response for the metrics Brave.Today.IsEnabled when brave news is turned OFF and ON via different NTP's

Steps to Reproduce

1. Clean profile 1.53.x
2. Open an NTP and scroll down to view brave news welcome screen and click on the No thanks button
3. Open brave://local-state
4. Look for the metrics Brave.Today.IsEnabled
5. Confirmed that the metrics Brave.Today.IsEnabled response value is 0 as expected
6. Open 2nd NTP
7. Click on the Customize->Brave News->Turn on Brave news via NTP dashboard settings in 2nd NTP
8. Reload brave://local-state, the metrics Brave.Today.IsEnabled response is still 0 instead of 1
9. Open 3rd NTP and view brave news feeds
10. Reload brave://local-state, the metrics Brave.Today.IsEnabled response is still 0 instead of 1
11. Exit the browser and restart
12. Reload brave://local-state, the metrics Brave.Today.IsEnabled response is still 0 instead of 1

Actual result:

Incorrect response for the metrics Brave.Today.IsEnabled when brave news is turned OFF and ON via different NTP's

Expected result:

Response should 1 when Brave news is enabled via 2nd NTP

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	1.53.74 Chromium: 114.0.5735.53 (Official Build) beta (64-bit)
Revision	c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS	Windows 10 Version 22H2 (Build 19045.2965)

Version/Channel Information:

• Can you reproduce this issue with the current release? NA
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @DJAndries @mattmcalister

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.54.64 Chromium: 114.0.5735.133 (Official Build) nightly (64-bit)
-- | --
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | Windows 10 Version 22H2 (Build 19045.3086)

1. Clean profile 1.54.x
2. Open an NTP and scroll down to view brave news welcome screen and click on the No thanks button
3. Open brave://local-state
4. Look for the metrics Brave.Today.IsEnabled
5. Confirmed that the metrics Brave.Today.IsEnabled response value is 0 as expected
6. Open 2nd NTP
7. Click on the Customize->Brave News->Turn on Brave news via NTP dashboard settings in 2nd NTP
8. Reload brave://local-state, the metrics Brave.Today.IsEnabled response is still 0 instead of 1
9. Open 3rd NTP and view brave news feeds
10. Reload brave://local-state, the metrics Brave.Today.IsEnabled response is still 0 instead of 1
11. Exit the browser and restart
12. Reload brave://local-state, the metrics Brave.Today.IsEnabled response is still 0 instead of 1

step 5	step 7	step 8	step 9	step 10	step 12

[kjozwiak]

Removing QA Pass-Win64 as the above will need to be re-checked via 1.53.x now that it's been uplifted via brave/brave-core#18935. @GeetaSarvadnya honestly, can probably just do a quick spot check as you've basically already checked this on 1.55.x & 1.54.x via #30709 (comment) & brave/brave-core#18701 (comment).

@DJAndries labelled it as Done but not sure about the wiki part of the above (not 100% sure what the process is)

[kjozwiak]

The above requires 1.53.104 or higher for 1.53.x verification 👍

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.53.104 Chromium: 115.0.5790.40 (Official Build) (64-bit)
-- | --
Revision | 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS | Windows 10 Version 22H2 (Build 19045.3086)

1. Clean profile 1.53.104
2. Open an NTP and scroll down to view brave news welcome screen and click on the No thanks button
3. Open brave://local-state
4. Look for the metrics Brave.Today.IsEnabled
5. Confirmed that the metrics Brave.Today.IsEnabled response value is 0 as expected
6. Open 2nd NTP
7. Click on the Customize->Brave News->Turn on Brave news via NTP dashboard settings in 2nd NTP
8. Reload brave://local-state, the metrics Brave.Today.IsEnabled response is still 0 instead of 1
9. Open 3rd NTP and view brave news feeds
10. Reload brave://local-state, the metrics Brave.Today.IsEnabled response is still 0 instead of 1
11. Exit the browser and restart
12. Reload brave://local-state, the metrics Brave.Today.IsEnabled response is still 0 instead of 1

step 5	step 7	step 8	step 9	step 10	step 12