Fix news P3A enabled metric

[DJAndries]

Resolves brave/brave-browser#30709

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

Follow plan in #18375

[petemill]

What's the problem with reporting the histogram twice - won't it just report only the most recent value for this metric?

[DJAndries]

not quite, it seems that when a user presses "no thanks" on Android, both prefs will be enabled in the first call, and then the "show today" pref will be disabled in the second call. if we don't have the timer, the first call will set the "was enabled" pref to true which will result in the "is enabled" metric being reported as 0 in the second call, which we don't want. the timer is here to make sure all edge cases are covered and increases robustness

[petemill]

This seems like a bug from Android. We should locate that part @deeppandya @tapanmodh ?

[tapanmodh]

@petemill sure. I'll check it

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.55.5 Chromium: 115.0.5790.32 (Official Build) nightly (64-bit)
-- | --
Revision | f9b78cf410ecd5b372310ef25a12ef456c77d90f-refs/branch-heads/5790@{#724}
OS | Windows 10 Version 22H2 (Build 19045.3086)

1. Clean profile 1.55.5
2. Open an NTP and scroll down to view brave news welcome screen and click on the No thanks button
3. Open brave://local-state
4. Look for the metrics Brave.Today.IsEnabled
5. Confirmed that the metrics Brave.Today.IsEnabled response value is 0 as expected
6. Open 2nd NTP
7. Click on the Customize->Brave News->Turn on Brave news via NTP dashboard settings in 2nd NTP
8. Reload brave://local-state, the metrics Brave.Today.IsEnabled response is still 0 instead of 1
9. Open 3rd NTP and view brave news feeds
10. Reload brave://local-state, the metrics Brave.Today.IsEnabled response is still 0 instead of 1
11. Exit the browser and restart
12. Reload brave://local-state, the metrics Brave.Today.IsEnabled response is still 0 instead of 1

step 5	step 7	step 8	step 9	step 10	step 12