Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download bubble doesn't open up when a file download is completed #30882

Closed
srirambv opened this issue Jun 7, 2023 · 3 comments · Fixed by brave/brave-core#18788
Closed

Download bubble doesn't open up when a file download is completed #30882

srirambv opened this issue Jun 7, 2023 · 3 comments · Fixed by brave/brave-core#18788

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 7, 2023

Description

Download bubble doesn't open up when a file download is completed

Steps to Reproduce

  1. Install 1.51.x and download a file
  2. Download bubble opens up when the file download is completed
  3. Upgrade to 1.52.x and download a second file
  4. Download bubble doesn't automatically open up when the file download is completed

Actual result:

Download bubble doesn't open up when a file download is completed

Expected result:

Probably open the download bubble when the download is complete

Reproduces how often:

Easy

Brave version (brave://version info)

1.52.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? Not checked but @GeetaSarvadnya mentioned its the same

Miscellaneous Information:

cc: @rebron @simonhong @brave/qa-team

Note: This regression came from brave/brave-core#17832

@stephendonner
Copy link

Here's @GeetaSarvadnya 's screencast showing it in action, in 1.51.x:

1 51

@simonhong simonhong self-assigned this Jun 7, 2023
simonhong added a commit to brave/brave-core that referenced this issue Jun 7, 2023
fix brave/brave-browser#30882

If we call bubble_controller()->GetMainView(), it makes every item "was_actioned".
When download completed, bubble includes un-actioned items.
But, it was all set as actioned already via GetMainView(), bubble doesn't have any
items to display. To get all items list w/o touching actioned state,
use DownloadBubbleUpdateService::GetAllModelsToDisplay().
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 8, 2023
@kjozwiak
Copy link
Member

The above requires 1.52.125 or higher for 1.52.x verification 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 13, 2023

Verification PASSED on

Brave | 1.52.125 Chromium: 114.0.5735.110 (Official Build) (64-bit)
-- | --
Revision | 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS | Windows 10 Version 22H2 (Build 19045.2965)
  • Confirm that the download bubble auto-open once the download completes.
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment