Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show alert icon in download button when insecure download is in-progress #17832

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 30, 2023

fix brave/brave-browser#29376
Screenshot 2023-03-31 at 11 32 19 AM
Screenshot 2023-03-31 at 11 32 40 AM

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@simonhong simonhong self-assigned this Mar 30, 2023
@simonhong simonhong force-pushed the show_warn_icon_in_download_button branch from 206c581 to 2106a1b Compare March 31, 2023 02:48
@simonhong simonhong force-pushed the show_warn_icon_in_download_button branch from 2106a1b to 970c053 Compare March 31, 2023 02:53
@simonhong simonhong marked this pull request as ready for review March 31, 2023 06:09
@simonhong simonhong requested a review from a team as a code owner March 31, 2023 06:09
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@goodov goodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with gn question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download indicator shows progress for insecure download, before allowing to download
3 participants