Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tipping panel view not showing on some YouTube channels #3335

Closed
Miyayes opened this issue Feb 13, 2019 · 9 comments · Fixed by brave/brave-core#1901
Closed

Tipping panel view not showing on some YouTube channels #3335

Miyayes opened this issue Feb 13, 2019 · 9 comments · Fixed by brave/brave-core#1901

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 13, 2019

Issue: Tipping panel not showing on some YouTube channels when they should be. Tipping interface only shows "Rewards Summary" view.

Platform: MacOS, 0.59.35.

Reproduce: Navigate to https://www.youtube.com/watch?v=9y2EvgxxMXc, and open the tipping panel.

image
Should show tipping view.

Notes: Early suspicions are that this related to localization, as this channel is in Korean.

@NejcZdovc NejcZdovc added QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. labels Feb 13, 2019
@NejcZdovc NejcZdovc self-assigned this Feb 14, 2019
@NejcZdovc NejcZdovc assigned jasonrsadler and unassigned NejcZdovc Feb 18, 2019
@jasonrsadler
Copy link

jasonrsadler commented Feb 19, 2019

@Miyayes @NejcZdovc

This publisher has turned off embedding for all of their videos. We cannot get the publisher information when they have this turned off.

Go to:
https://www.youtube.com/oembed?format=json&url=https://www.youtube.com/watch?v=9y2EvgxxMXc and you will see Unauthorized. Other videos that have embedding enabled you can plug in to see the json results using https://www.youtube.com/oembed?format=json&url= + the entire video url.

The panel shows the publisher on their channel page.

This is not due to localization as other Korean language videos show up properly:

screen shot 2019-02-18 at 8 34 42 pm

For the above publisher, you can see the info we use at:
https://www.youtube.com/oembed?format=json&url=https://www.youtube.com/watch?v=siBA2iZZmdw because embedding is not disabled.

@jasonrsadler jasonrsadler added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Feb 19, 2019
@jasonrsadler
Copy link

@NejcZdovc How should we handle the panel for publisher videos that have embedding disabled?

@NejcZdovc
Copy link
Contributor

@jasonrsadler if we get 401 let's get info from the page

@rebron
Copy link
Collaborator

rebron commented Mar 28, 2019

@NejcZdovc Does this need to be uplifted to 62.x, make the appropriate PR and tag us again please.

@NejcZdovc
Copy link
Contributor

@rebron we have uplift for 0.63 brave/brave-core#2092

@btlechowski
Copy link

Verification passed on

Brave 0.63.30 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

Used test plan from brave/brave-core#1756

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 7, 2019

@NejcZdovc The issue is still reproducible for a few YT videos. When the video is opened in a new tab, pubs info will not be shown in BR panel.
https://www.youtube.com/channel/UCU_JoWTHBXzbfEByl5GahYg
https://www.youtube.com/channel/UC6uj6iimYkg4f1lpc7BItoA

https://drive.google.com/open?id=1mWcZnwy3z0mmk0id8Wj6cOBFpzCkErxa

Brave 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

@jasonrsadler
Copy link

jasonrsadler commented Apr 7, 2019

@NejcZdovc I'm on latest master (0.65) and no media publishers are showing for me (youtube or twitch).

@btlechowski
Copy link

btlechowski commented Apr 16, 2019

Verification passed on

Brave 0.63.42 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Ubuntu 18.04 LTS

Used test plan from brave/brave-core#1756 and #3335 (comment)

Verified passed with

Brave 0.63.44 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X

Verification passed on

Brave 0.63.44 Chromium: 74.0.3729.75 (Official Build) beta (64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Windows 10 OS Build 17134.523

Used test plan from brave/brave-core#1756 and #3335 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment