Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube videos with embedding disabled now show properly in Rewards panel #2092

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

jasonrsadler
Copy link
Contributor

Fixes brave/brave-browser#3335

Original PR: #1756

Youtube videos with embedding disabled now show properly in Rewards panel
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonrsadler can you double check and make sure that the travis and jenkins failures are not related to this specific PR?

I went through the test plan via #1756 using 0.65.5 Chromium: 73.0.3683.75 and it looks like everything is working. Example of this PR/fix working under 0.65.5 Chromium: 73.0.3683.75:

Screen Shot 2019-04-02 at 6 16 13 PM

Just need a confirmation/double check to make sure that this PR didn't cause the failed travis & jenkins failures.

@jasonrsadler jasonrsadler dismissed kjozwiak’s stale review April 3, 2019 00:07

CI passes. PRB failure is unrelated

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 0.63.x approved after the required checks have been completed. I also ensured that the following PR was working under 0.65.5 Chromium: 73.0.3683.75 via #2092 (review). Also deliberated with both @srirambv @rebron as well 👍

Please make sure that all the correct labels are being used and that the appropriate issue is moved into the correct milestone.

@jasonrsadler jasonrsadler merged commit ba9a2d8 into 0.63.x Apr 3, 2019
@jasonrsadler jasonrsadler deleted the yt-oembed-disabled-63 branch April 3, 2019 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants