Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Google login integrations do not work #3534

Closed
mrzealot opened this issue Feb 28, 2019 · 2 comments · Fixed by brave/brave-core#1818
Closed

Some Google login integrations do not work #3534

mrzealot opened this issue Feb 28, 2019 · 2 comments · Fixed by brave/brave-core#1818
Assignees
@mrzealot
Labels
feature/shields/cookies Cookie controls implemented as part of Shields. priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude webcompat/shields Shields is breaking a website.
Milestone
0.62.x - Release ...

Comments

@mrzealot
Copy link

mrzealot commented Feb 28, 2019 •
edited by bbondy
Loading

Embedded Google login integrations break with shields up. This is due to iframes loading pages from accounts.google.com and not being able to set cookies.
Examples include:

Note that there are numerous other Google login integrations that work just fine because they use a redirect-based authentication instead of the embedded iframes.
@mrzealot mrzealot self-assigned this Feb 28, 2019
@mrzealot mrzealot added webcompat/shields Shields is breaking a website. feature/shields/cookies Cookie controls implemented as part of Shields. labels Feb 28, 2019
@mrzealot mrzealot mentioned this issue Feb 28, 2019
Closed
18 tasks
mrzealot pushed a commit to brave/brave-core that referenced this issue Mar 1, 2019
1st-party-independent cookie exception for Google auth (fixes brave/b…
ee53f9a 
…rave-browser#3534)

This also fixes brave/brave-browser#3115 and brave/brave-browser#1179.
@bbondy bbondy changed the title Fix certain Google login integrations Some Google login integrations do not work Mar 5, 2019
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 5, 2019
bbondy pushed a commit to brave/brave-core that referenced this issue Mar 11, 2019
@bbondy
1st-party-independent cookie exception for Google auth (fixes brave/b…
6874c8c 
…rave-browser#3534)

This also fixes brave/brave-browser#3115 and brave/brave-browser#1179.
@bbondy bbondy mentioned this issue Mar 11, 2019
Merged
19 tasks
@bbondy bbondy added the QA/No label Mar 12, 2019
@bbondy
Copy link
Member

bbondy commented Mar 12, 2019

Marking as QA/No since test case for this is covered in #3489

bbondy pushed a commit to brave/brave-core that referenced this issue Mar 12, 2019
@bbondy
1st-party-independent cookie exception for Google auth (fixes brave/b…
0edab2c 
…rave-browser#3534)

This also fixes brave/brave-browser#3115 and brave/brave-browser#1179.
bbondy pushed a commit to brave/brave-core that referenced this issue Mar 15, 2019
@bbondy
1st-party-independent cookie exception for Google auth (fixes brave/b…
ec009bb 
…rave-browser#3534)

This also fixes brave/brave-browser#3115 and brave/brave-browser#1179.
@bbondy bbondy added this to the 0.63.x - Dev milestone Mar 15, 2019
This was referenced Mar 15, 2019
Merged
Merged
@bbondy bbondy removed this from the 0.63.x - Dev milestone Mar 18, 2019
@bbondy bbondy added this to the 0.62.x - Beta milestone Mar 18, 2019
@bridiver
Copy link
Contributor

all of these sites appear to work now without the cookie whitelist preference
brave/brave-core#3260

@bsclifton bsclifton mentioned this issue Dec 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrzealot mrzealot

Labels
feature/shields/cookies Cookie controls implemented as part of Shields. priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude webcompat/shields Shields is breaking a website.
Projects
None yet
Milestone
0.62.x - Release (Release Channel)
4 participants
@bridiver @mrzealot @bbondy @rebron