Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add social blocking options #1968

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Add social blocking options #1968

merged 2 commits into from
Mar 18, 2019

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Mar 15, 2019

@bbondy bbondy requested a review from a team March 15, 2019 16:50
@NejcZdovc NejcZdovc added this to the 0.63.x - Dev milestone Mar 15, 2019
@bbondy bbondy changed the title Merge pull request #1818 from brave/social-blocking-options Add social blocking options Mar 15, 2019
kjozwiak
kjozwiak previously approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 0.63.x approved after deliberating with @rebron. Please ensure that all associated issues are moved into the correct milestone 👍

@bbondy can you get a 0.62.x PR going as well?

@bbondy bbondy self-assigned this Mar 15, 2019
@bbondy
Merge pull request #1987 from brave/social-blocking-proxy-fix
1a95e65 
Fix SocialBlockingBrowserProxyImpl class name
@bbondy bbondy merged commit 41991e5 into 0.63.x Mar 18, 2019
@mihaiplesa mihaiplesa deleted the social-blocking-options-0.63.x branch May 13, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak left review comments

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
0.63.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@bbondy @kjozwiak @NejcZdovc