Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All publishers calls should go through ledger code #4025

Closed
NejcZdovc opened this issue Apr 5, 2019 · 1 comment · Fixed by brave/brave-core#2166
Closed

All publishers calls should go through ledger code #4025

NejcZdovc opened this issue Apr 5, 2019 · 1 comment · Fixed by brave/brave-core#2166
Assignees
@NejcZdovc
Labels
dev-concern feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.65.x - Release ...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 5, 2019 •
edited
Loading

After additional check we have two more functions that involves publisher and are called directly from rewards service. All calls should go through ledger code.

  1. LoadPublisherInfo https://github.com/brave/brave-core/blob/aa28d5e02521e03c0bed83b4237e039da7eb0343/components/brave_rewards/browser/rewards_service_impl.cc#L1121

  2. GetContentSiteList https://github.com/brave/brave-core/blob/aa28d5e02521e03c0bed83b4237e039da7eb0343/components/brave_rewards/browser/rewards_service_impl.cc#L491
@NejcZdovc NejcZdovc self-assigned this Apr 5, 2019
This was referenced Apr 5, 2019
Closed
Merged
NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 5, 2019
@NejcZdovc
Moves GetActivityInfoList into ledger code
77fa067 
Resolves brave/brave-browser#4025
@NejcZdovc NejcZdovc mentioned this issue Apr 5, 2019
Merged
19 tasks
@NejcZdovc NejcZdovc added this to the 0.65.x - Nightly milestone Apr 6, 2019
pilgrim-brave pushed a commit to brave/brave-core that referenced this issue Apr 16, 2019
@NejcZdovc @pilgrim-brave
Moves GetActivityInfoList into ledger code
d2526d2 
Resolves brave/brave-browser#4025
This was referenced May 10, 2019
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented May 20, 2019 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Verification passed on

Brave 0.65.98 Chromium: 74.0.3729.131 (Official Build) beta (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

Verification passed on

Brave 0.65.107 Chromium: 75.0.3770.38 (Official Build) beta (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
dev-concern feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.65.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Moves GetActivityInfoList and LoadPublisherInfo into ledger code brave/brave-core
4 participants
@NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya