Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves GetActivityInfoList and LoadPublisherInfo into ledger code #2166

Merged
merged 2 commits into from
Apr 6, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 5, 2019

Resolves brave/brave-browser#4025

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

plan 1

  • clean profile
  • enable rewards
  • close rewards page (if opened)
  • visit some site and stay there for 10+s
  • go to rewards page and make sure that the site is in AC list

plan 2

  • clean profile
  • enable rewards
  • add one site to ac table
  • close that site and go to rewards page
  • exclude it and then restore all sites
  • go to that site and immediately open panel
  • make sure that you see correct publisher info in the panel

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc self-assigned this Apr 5, 2019
@NejcZdovc NejcZdovc requested review from bridiver, bbondy, jasonrsadler and ryanml and removed request for bridiver and bbondy April 5, 2019 12:54
@NejcZdovc NejcZdovc marked this pull request as ready for review April 5, 2019 12:54
Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes and/or questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All publishers calls should go through ledger code
2 participants