Update source for search suggestions

[deeppandya]

Description

We need to update the source for search suggestions similar to source attached to searches. Currently we have source=browser for all platforms. In this issue, we need to update source=android for android and source=desktop for desktop.

For more ref : https://bravesoftware.slack.com/archives/C0816QH3R/p1726178343456589

[deeppandya]

CC @rebron for the visibility

[LaurenWags]

Requires 1.71.103 or higher for verification 👍🏻

[MadhaviSeelam]

Verification PASSED using

Brave | 1.71.111 Chromium: 130.0.6723.31 (Official Build) (64-bit)
-- | --
Revision | a39f12f230248c726d3f1cac2d59dd4dcac714d7
OS | Windows 11 Version 23H2 (Build 22631.4317)

New user (Brave Search default) - PASSED

1. Installed 1.71.111
2. launched Brave
3. opened Fiddler to track network traffic.
4. relaunched Brave
5. verified Brave is default SE for my default location (i.eUnited States)
6. open NTP
7. In the omnibox, started typing a search term (eg. milton)
8. confirmed in Fiddler that the search suggestions API URL contains source=desktop
9. opened another NTP
10. In the search widget, started typing a search term
11. confirmed in Fiddler that the search suggestions API URL contains source=desktop

step 5	step 7	step 8	step 10	step 11

New user (start with non-Brave Search default and change to Brave Search) - PASSED

Pre-req: Have OS set to a region where Brave Search is not the default SE (ex. Vietnam)

1. Installed 1.71.111 and launched
2. Closed 1.71.111 . Opened Fiddler to track network traffic.
3. Relaunch Brave
4. Confirmed that when in a region without Brave as default SE (ex. Vietnam), that Brave is not the default SE and search suggestions are not enabled.
5. Change Normal window SE to Brave
6. Enable search suggestions
7. Open NTP
8. In the omnibox, started typing a search term
9. Confirmed in Fiddler that the search suggestions API URL contains source=desktop
10. Opened another NTP
11. In the search widget, started typing a search term
12. Confirmed in Fiddler that the search suggestions API URL contains source=desktop

OS change	step 4	step 5-6	step 8	step 9	step 11	step 12

Existing/Upgraded user (Brave Search default) - PASSED

1. Installed 1.70.126 version of Nightly (ex. https://github.com/brave/brave-browser/releases/tag/v1.71.82) and launched
2. Closed 1.70.126 Opened Fiddler to track network traffic.
3. Relaunch Brave - check brave://version to ensure you're not updated to 1.71.x.
4. Confirmed that when in a region with Brave as default SE (ex. United States), that Brave is the default SE and search suggestions are enabled.
5. Open NTP
6. In the omnibox, started typing a search term
7. Confirmed in Fiddler that the search suggestions API URL contains source=browser
8. Opened another NTP
9. In the search widget, started typing a search term
10. Confirmed in Fiddler that the search suggestions API URL contains source=browser
11. Close browser
12. Install 1.71.111 higher and relaunch
13. verified Brave still default and search suggestions are enabled
14. In the omnibox, started typing a search term
15. Confirmed in Fiddler that the search suggestions API URL contains source=desktop
16. Opened another NTP or go to existing NTP
17. In the search widget, started typing a search term
18. Confirmed in Fiddler that the search suggestions API URL contains source=desktop

step 1	step 3	step 4	step 6	step 7	step 9	step 10	step 12	step 13	step 14	step 15	step 17	step 18

Existing/Upgraded user (start with non-Brave Search default and change to Brave Search) - PASSED

Pre-req: Have OS set to a region where Brave Search is not the default SE (ex. Vietnam)

1. Installed current release 1.70.126
2. Closed 1.70.126. Opened Fiddler to track network traffic.
3. Relaunch Brave - check brave://version to ensure you're not updated to 1.71.111
4. Confirmed that when in a region without Brave as default SE (ex. Vietnam), that Brave is not the default SE and search suggestions are enabled.
5. Change Normal window SE to Brave
6. Enable search suggestions
7. Open NTP
8. In the omnibox, started typing a search term
9. Confirmed in Fiddler that the search suggestions API URL contains source=browser
10. Opened another NTP
11. In the search widget, started typing a search term
12. Confirmed in Fiddler that the search suggestions API URL contains source=browser
13. Close the browser, install 1.71.111
14. Relaunch
15. verified Brave is still shown as default SE in brave://settings/search
16. In the omnibox, started typing a search term
17. Confirmed in Fiddler that the search suggestions API URL contains source=desktop
18. Opened another NTP or go to existing NTP
19. In the search widget, started typing a search term
20. Confirmed in Fiddler that the search suggestions API URL contains source=desktop

OS change	step 1	step 4	step 5	step 8	step 9	step 11	step 12	step 13	step 15	step 16	step 17	step 19	step 20

[Uni-verse]

Verified on Samsung Galaxy S21 using version:

Brave	1.71.111 Chromium: 130.0.6723.31 (Official Build) (64-bit) 
Revision	a39f12f230248c726d3f1cac2d59dd4dcac714d7
OS	Android 13; Build/TP1A.220624.014; 33; REL

New user (Brave Search default)

1. New install (US)
2. Enter search term in omnibox
3. Monitor search.brave.com using proxy

• Ensured search suggestions URL contains query components &source=android

New user (Non-Brave Search initial, change to Brave Search)

1. New install
2. Confirm Brave is not default SE (Singapore)
3. Change SE to Brave Search
4. Enable search suggestions
5. Enter search term in omnibox
6. Monitor search.brave.com using proxy

• Ensured search suggestions URL contains query components &source=android

Existing users (Brave Search default)

1. Install 1.70 (US)
2. Upgrade to 1.71.112
3. Enter search term in omnibox
4. Monitor search.brave.com using proxy

• Ensured search suggestions URL contains query components &source=android

Existing users (Non-Brave Search initial, change to Brave Search)

1. Install 1.70 (Singapore)
2. Upgrade to 1.71.112
3. Change default SE to Brave
4. Enable search suggestions
5. Enter search term in omnibox
6. Monitor search.brave.com using proxy

• Ensured search suggestions URL contains query components &source=android