Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update source for search suggestion for android & desktop (uplift to 1.71.x) #25680

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Update source for search suggestion for android & desktop (uplift to 1.71.x) #25680

merged 2 commits into from
Oct 1, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 20, 2024 •
edited by LaurenWags
Loading

Uplift of #25627
Resolves brave/brave-browser#41112

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner September 20, 2024 19:05
@brave-builds brave-builds requested a review from a team September 20, 2024 19:05
@brave-builds brave-builds added this to the 1.71.x - Beta milestone Sep 20, 2024
@brave-builds brave-builds self-assigned this Sep 20, 2024
@bsclifton
Copy link
Member

Note for approvers:
We'll want to wait until #25731 is merged and then this can be cherry-picked into this PR also. As-is, I don't think the suggestions will work as expected for existing users. New users should get the value without an issue

@bsclifton
Copy link
Member

OK ready for consideration 😄

@bsclifton bsclifton force-pushed the pr25627_update_source_for_search_suggestions_1.71.x branch from 89797f7 to d70b593 Compare October 1, 2024 16:39
LaurenWags
LaurenWags approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.71.x is approved 👍🏻 QA has verified the PR on 1.72.x/Nightly as per #25627 (comment) (desktop) and #25627 (comment) (android).

@LaurenWags LaurenWags merged commit 25abb5c into 1.71.x Oct 1, 2024
15 checks passed
@LaurenWags LaurenWags deleted the pr25627_update_source_for_search_suggestions_1.71.x branch October 1, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.71.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @bsclifton @LaurenWags