Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reapply "[Rounded Corners]: Fix WebContents shadow in light mode" with fixes #41496

Closed
fallaciousreasoning opened this issue Oct 8, 2024 · 2 comments · Fixed by brave/brave-core#25895
Closed

Reapply "[Rounded Corners]: Fix WebContents shadow in light mode" with fixes #41496

fallaciousreasoning opened this issue Oct 8, 2024 · 2 comments · Fixed by brave/brave-core#25895
Assignees
@fallaciousreasoning
Labels
feature/user-interface All UI related OS/Desktop QA/Yes release-notes/exclude
Milestone
1.73.x - Nightly

Comments

@fallaciousreasoning
Copy link

brave/brave-core#25738 was reverted because it was causing crashes in Nightly. We should fix the crashes and reland it.
@fallaciousreasoning fallaciousreasoning self-assigned this Oct 8, 2024
@fallaciousreasoning fallaciousreasoning mentioned this issue Oct 8, 2024
Merged
24 tasks
@simonhong
Copy link
Member

@fallaciousreasoning Can you attach crash log in this issue?

@simonhong
Copy link
Member

Ah, NVM I found - #41465 (comment)

@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Oct 10, 2024
@brave-builds brave-builds mentioned this issue Oct 11, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallaciousreasoning fallaciousreasoning

Labels
feature/user-interface All UI related OS/Desktop QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.73.x - Nightly
Development

Successfully merging a pull request may close this issue.

Reapply "[Rounded Corners]: Fix WebContents shadow in light mode" with fixes brave/brave-core
3 participants
@simonhong @fallaciousreasoning @brave-builds