Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "[Rounded Corners]: Fix WebContents shadow in light mode" with fixes #25895

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Oct 8, 2024

Resolves brave/brave-browser#41496

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See #25738

Additional steps for crash:

  1. Start a new profile
  2. Enable vertical tabs
  3. Set vertical tabs to collapsed, expand on hover
  4. Restart Brave

Brave should not crash

@fallaciousreasoning fallaciousreasoning merged commit 35b8f12 into master Oct 10, 2024
17 checks passed
@fallaciousreasoning fallaciousreasoning deleted the rounded-corners-again branch October 10, 2024 19:25
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 10, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reapply "[Rounded Corners]: Fix WebContents shadow in light mode" with fixes
4 participants