Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seek (forward or backward) on vimeo video messes up entire AC table #5725

Closed
LaurenWags opened this issue Aug 19, 2019 · 6 comments · Fixed by brave/brave-core#3209
Closed

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Aug 19, 2019

Description

Found while testing #4017

If you watch a vimeo video normally, your AC table is fine. However, if you start seeking (forward or backward), the AC table gets really messed up.

Steps to Reproduce

  1. Clean profile on 0.68.x

  2. Enable Rewards (keep this open in one window)

  3. Open a second window and visit some sites - a mix: regular sites, youtube videos, etc.

  4. Watch a vimeo video. See it added to AC table. Note its percentage. If you check publisher_info_db at this point, you see normal values for duration, score, etc.
    Screen Shot 2019-08-19 at 1 59 25 PM

  5. Once it's added to the table, move the slider bar forward (essentially fast forwarding the video)

  6. See the % for vimeo video increased on brave://rewards page without actually watching since you fast forwarded. This shouldn't happen.
    Screen Shot 2019-08-19 at 1 59 54 PM

  7. Move slider bar close to the beginning of the video. See vimeo video removed from AC table. If you check publisher_info_db at this point, you could see a negative value for duration (depending on how much of the video you had watched). This shouldn't happen.

Screen Shot 2019-08-19 at 2 00 07 PM

Screen Shot 2019-08-19 at 2 00 53 PM

  1. Watch vimeo video for a bit. It will get added back to AC table but it is now at 100%, all other sites that were there previously are gone. If you check publisher_info_db at this point, you will see a normal looking duration, but your score is extremely high.

Screen Shot 2019-08-19 at 2 04 27 PM
Screen Shot 2019-08-19 at 2 06 27 PM

  1. If you try to add sites to your auto contribute table at this point, they won't add. I'm guessing bc the score for the vimeo video is so high.

Note - I could not reproduce this with a YouTube video in place of vimeo video.

Actual result:

Seek (forward/backward) on vimeo video screws up ac table.

Expected result:

AC table not wiped out, duration to be accurately recorded.

Reproduces how often:

Seems to reproduce easily with seek forward/backward

Brave version (brave://version info)

Brave 0.68.130 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? 0.67.x n/a, 0.68.x yes
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

If you watch vimeo normally this doesn't appear to happen.

@LaurenWags
Copy link
Member Author

Note - if at step 8 you remove this publisher from your AC table, your previous entries come back.

@btlechowski
Copy link

Reproduced on Ubuntu

Brave 0.68.130 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

image

@GeetaSarvadnya
Copy link

The issue is Reproducible in windows 10 x64 -0.68.130. The issue is NOT 100% reproducible on all Vimeo videos, Vimeo video has to be forward and backward multiple times only then the issue is reproducible.

@LaurenWags
Copy link
Member Author

Additional notes:

  1. You don't need to go forward first for this to happen. Moving the seek bar back will cause the large score value and screw up your AC table. (making the vimeo pub the only entry)
  2. Moving the seek bar forward only does not increase the score value in publisher_info_db. It does inflate your duration though (so you are getting an inaccurate amount of time viewed). This does not screw up your entire AC table though.
  3. If you Pause before moving seek bar back towards beginning of the video, you don't get the large score value and your AC table doesn't get messed up.

@rebron rebron added this to the 0.68.x - Release milestone Aug 19, 2019
@LaurenWags
Copy link
Member Author

@NejcZdovc here are some simpler steps:

  1. clean profile, enable rewards
  2. visit some sites so you have a few in your ac table
  3. view a vimeo video
  4. once it's added to your ac table, move the slider bar back toward the beginning of the video (doesn't have to be right at the start)
  5. wait a bit, your ac table will clear and you'll only have one entry - the vimeo publisher at 100%. checking your publisher_info_db will show an insanely high score value. mine was 36million.

@LaurenWags
Copy link
Member Author

LaurenWags commented Aug 20, 2019

Verified passed with

Brave 0.68.131 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X
  • Verified test plan from Fixes seek on Vimeo brave-core#3209
  • Verified STR from description
  • Existing AC table entries were not wiped out when seeking (fwd or back) on vimeo video
  • Verified able to add sites to ac table after seeking on a vimeo video
  • No unusual score or duration observed in publisher_info_db activity table.
  • Verified using verified and non-verified vimeo publishers
    5725

Verification passed on

Brave 0.68.131 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS
  • Verified test plan from Fixes seek on Vimeo brave-core#3209
  • Verified STR from description
  • Existing AC table entries were not wiped out when seeking (fwd or back) on vimeo video
  • Verified able to add sites to ac table after seeking on a vimeo video
  • No unusual score or duration observed in publisher_info_db activity table.
  • Verified using verified and non-verified vimeo publishers

Verification passed on

Brave 0.68.131 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified test plan from Fixes seek on Vimeo brave-core#3209
  • Verified STR from the description
  • Existing AC table entries were not wiped out when seeking (fwd or back) on vimeo video
  • Verified able to add sites to ac table after seeking on a vimeo video
  • No unusual score or duration observed in publisher_info_db activity table.
  • Verified using verified and non-verified vimeo publishers

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment