-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes seek on Vimeo #3209
Fixes seek on Vimeo #3209
Conversation
@@ -168,6 +168,10 @@ uint64_t Vimeo::GetDuration( | |||
} | |||
} | |||
|
|||
if (time < 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't allow negative time. This happen when you seek back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@NejcZdovc @emerick mind taking a quick look at https://staging.ci.brave.com/job/brave-browser-build-pr/job/seek-vimeo/2/execution/node/218/log/. Assuming it went >6hrs as per:
|
Resolves brave/brave-browser#5725
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.