Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes seek on Vimeo #3209

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Fixes seek on Vimeo #3209

merged 1 commit into from
Aug 20, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 19, 2019

Resolves brave/brave-browser#5725

Submitter Checklist:

Test Plan:

  • enable rewards
  • go to vimeo video
  • wait for vimeo to appear in AC table
  • seek to the beginning
  • make sure that DB entry in activity_info doesn't explode

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@@ -168,6 +168,10 @@ uint64_t Vimeo::GetDuration(
}
}

if (time < 0) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't allow negative time. This happen when you seek back.

emerick
emerick previously approved these changes Aug 19, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjozwiak
Copy link
Member

@NejcZdovc @emerick mind taking a quick look at https://staging.ci.brave.com/job/brave-browser-build-pr/job/seek-vimeo/2/execution/node/218/log/. Assuming it went >6hrs as per:

Cancelling nested steps due to timeout
Body did not finish within grace period; terminating with extreme prejudice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seek (forward or backward) on vimeo video messes up entire AC table
3 participants