Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Infobars for Dapp detection and MetaMask detection #3791

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Oct 24, 2019

Fix brave/brave-browser#6600

Screenshots are available in the above issue.

This adds an InfoBar when web3 is detected on a page.
If MetaMask is already installed it gives the user the option to keep
MetaMask or use Brave wallet.

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bbondy bbondy self-assigned this Oct 24, 2019
@bbondy bbondy force-pushed the crypto-wallets-infobar branch 2 times, most recently from d0bf901 to c4676de Compare October 28, 2019 18:57
@bbondy bbondy requested review from emerick and ryanml October 28, 2019 19:41
@bbondy bbondy marked this pull request as ready for review October 28, 2019 19:41
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy force-pushed the crypto-wallets-infobar branch 4 times, most recently from d8e6824 to a6045ab Compare October 30, 2019 14:09
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

This adds an InfoBar when web3 is detected on a page.
If MetaMask is already installed it gives the user the option to keep
MetaMask or use Brave wallet.
@bbondy bbondy merged commit 9f0f0dc into master Oct 31, 2019
@bbondy bbondy deleted the crypto-wallets-infobar branch October 31, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use infobars for Dapp detection and warn for MetaMask
3 participants