Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tips not going thru when tokens are not standardized to 0.25 value #7608

Closed
LaurenWags opened this issue Jan 6, 2020 · 4 comments · Fixed by brave/brave-core#4317
Closed

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jan 6, 2020

Description

If you have a wallet with VG and other BAT, tips are not going through. I experienced this on Nightly, @NejcZdovc experienced this on Dev.

Steps to Reproduce

Case #1

This is my scenario, @NejcZdovc has one that might be different

  1. Have Rewards enabled and have non-VG BAT in your anon wallet.
  2. Claim Ad grant (VG).
  3. Attempt to tip.
  4. Tip does not show up in Tips panel on brave://rewards. Wallet balance does not go down.

Case #2

Actual result:

Tip does not go thru

Expected result:

Tip should go thru.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.5.10 Chromium: 79.0.3945.88 (Official Build) nightly (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)

@NejcZdovc reproduced on Dev as well.

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the dev channel? yes (@NejcZdovc ) - 1.4.x
  • Can you reproduce this issue with the nightly channel? yes (@LaurenWags ) - 1.5.10

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc to add his details/scenario

@rebron rebron added this to the 1.3.x - Beta milestone Jan 6, 2020
@jsecretan jsecretan added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Jan 6, 2020
@LaurenWags
Copy link
Member Author

Reproduced in Dev using the following scenario:

Clean profile Dev (1.4.x) enable Rewards (staging)
Restore a wallet from Ad grant spreadsheet
Claim Ad grant
Claim UGP grant
Attempt to tip 3sistemi 1BAT.
Tip does not go thru and is not listed on brave://rewards

Profile for this scenario provided to @NejcZdovc

Brave 1.4.52 Chromium: 79.0.3945.88 (Official Build) dev (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 7, 2020

Using (#7608 (comment) Reproduced the issue in Windows 10 x64 - 1.4.52

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 7, 2020

The issue is reproduced in Windows 10 x64 - 1.3.85

  1. Clean profile staging env
  2. Claim UGP grants
  3. Send a one-time tip to a verified pubs
  4. Send a monthly tip to a verified pubs

Actual:

NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 8, 2020
@NejcZdovc NejcZdovc changed the title tips not going thru when user has VG and other BAT tips not going thru when tokens are not standardized to 0.25 value Jan 8, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 9, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 9, 2020
gdregalo pushed a commit to brave/brave-core that referenced this issue Jan 10, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Jan 17, 2020

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave 1.3.94 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.15.2 (Build 19C57)

Example of VG + UGP grant:

Screen Shot 2020-01-17 at 3 46 07 PM

Verification passed on

Brave 1.3.94 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Example of VG + UGP grant:

image

Verification passed on

Brave 1.3.96 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants