[P3A] Incorrect value set for Q12 / WalletBalance (Brave.Rewards.WalletBalance.2) #8296

srirambv · 2020-02-18T12:22:19Z

Description

[P3A] Incorrect value set for WalletBalance [Follow up to #7633]

Steps to Reproduce

Scenario 1:

Clean install 1.3.116
Open local-state
Brave.Rewards.WalletBalance.2 is set to 0 (as expected)
Enable Rewards
Brave.Rewards.WalletBalance.2 is set to 2[10-50 BAT, excluding grants] instead of 1[Less than 10 BAT (0-9), excluding grants]

Scenario 2:

Clean install 1.3.116
Open local-state
Brave.Rewards.WalletBalance.2 is set to 0 (as expected)
Enable Rewards
Brave.Rewards.WalletBalance.2 is set to 2[10-50 BAT, excluding grants] instead of 1[Less than 10 BAT (0-9), excluding grants]
Claim UGP grant
Brave.Rewards.WalletBalance.2 is set to 3[Over 50 BAT, excluding grants] instead of 1 [Less than 10 BAT (0-9), excluding grants]

Actual result:

Incorrect value set for WalletBalance

Expected result:

Correct values for excluding grants should be set

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision	f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS	Linux

Version/Channel Information:

Can you reproduce this issue with the current release? Yes
Can you reproduce this issue with the beta channel? Yes
Can you reproduce this issue with the dev channel? Yes
Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? NA
Does the issue resolve itself when disabling Brave Rewards? NA
Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

Incorrect value is set on current release version as well. May be related to #7235. Issue reproduced on Windows by @GeetaSarvadnya .
cc: @iefremov @rebron

The text was updated successfully, but these errors were encountered:

LaurenWags · 2020-02-18T21:37:29Z

Reproduced on macOS.

Brave	1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision	f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS	macOS Version 10.14.6 (Build 18G3020)

Restored a wallet with 28 BAT (no grants). Expected "Brave.Rewards.WalletBalance.2" value to be 3 for "10-50 BAT, excluding grants", however it is still displaying 2, even after browser restart.

GeetaSarvadnya · 2020-06-04T15:11:29Z

In one more scenario, the wallet balance is not shown correctly. Reproduced the issue in both 1.11.x and 1.9.x

Clean profile
Enable rewards
Brave.Rewards.WalletBalance.2 is set to 2 as expected
Restore a wallet ( which has balance 1)
Claim UGP grants of 20 BAT
Brave.Rewards.WalletBalance.2 is set to 3 10-50 BAT, excluding grants, instead of 2 Less than 10 BAT (0-9), excluding grants

GeetaSarvadnya · 2021-05-28T11:17:15Z

Verification passed on



<!--StartFragment-->
Brave | 1.26.43 Chromium: 91.0.4472.77&nbsp;(Official Build)&nbsp;beta&nbsp;(64-bit)
-- | --
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

<!--EndFragment-->

Verified the test plan from Fix WalletBalance P3A responses brave-core#8734 and cases from the description

Clean profile

Scenario 1: Check the response value when no wallet created

Confirmed there is no Brave.Rewards.WalletBalance.2 stats display in brave://local-state/ when Rewards is NOT enabled which is expected as per the new implementation.

Scenario 2: Check the response value when the rewards is enabled

Confirmed that the response value is displayed as 2 (Less than 10 BAT (0-9), excluding grants) when rewards is enabled

Scenario 3: Check the response value when restore a wallet which has balance 1

Confirmed that the response value is displayed as 2 (Less than 10 BAT (0-9), excluding grants) when wallet is restored and balance is 1 BAT

Scenario 4: Check the response value when Claim UGP grants+restore a user funded wallet

Confirmed that the response value is displayed as 2 (Less than 10 BAT (0-9), excluding grants)

Scenario 5: Check the response value when uphold wallet (over 50 BAT balance) is connected and UGP grants claimed

Confirmed that the response value is displayed as 4 (Over 50 BAT, excluding grants)

Scenario 6: Check the response value when uphold wallet (with 0 BAT balance) is connected

Confirmed that the response value is displayed as 2 (Less than 10 BAT (0-9), excluding grants)

Scenario 7: Check the response value when uphold wallet (with 0 BAT balance) is connected and UGP grants claimed

Confirmed that the response value is displayed as 2 (Less than 10 BAT (0-9), excluding grants)

Scenario 8: Check the response value when Ad grants is claimed (23 BAT Ad grants)

Confirmed that the response value is displayed as 2 (Less than 10 BAT (0-9), excluding grants)

Scenario 9: Check the response value when Ad grants is claimed (23 BAT Ad grants)+ 10 BAT (from QA Uphold) is deposited to the wallet

Confirmed that the response value is displayed as 3 (10-50 BAT, excluding grants)

Scenario 10: Check the response value when one-time tip is sent from uphold wallet (which has balance less than 10 BAT deposited fund )

Confirmed that the response value is displayed as 2 (Less than 10 BAT (0-9), excluding grants)

Scenario 11: check the response value when rewards is disabled ( Ads and AC switches are off)

Confirmed that the response value for Brave.Rewards.WalletBalance.2 is displayed as 1 (Rewards Disabled)

Upgrade profile

Scenario 12: Install 1.25.x and enable rewards and upgrade profile to 1.26.x and _check the response value when the rewards is enabled

Confirmed that the response value for Brave.Rewards.WalletBalance.2 is displayed as 2 (Less than 10 BAT (0-9), excluding grants) when rewards is enabled

Scenario 13: Install 1.25.x and enable rewards and restore a wallet which has balance >100 BAT and then upgrade profile to 1.26.x

Confirmed that the response value for Brave.Rewards.WalletBalance.2 is displayed as 4 (Over 50 BAT, excluding grants) when wallet is restored and balance >100 BAT

Scenario 14: Install 1.25.x and enable rewards and connect uphold wallet and then upgrade profile to 1.26.x

Install 1.25.x and enable rewards
Connect uphold wallet which has balance <10 BAT
Upgrade profile to 1.26.x
Confirmed response value 2 is shown correctly in 1.26.x
Deposited funds to uphold wallet via QA uphold and make sure balance is above 50 BAT
Confirmed response value 4 is shown correctly

uphold wallet<10 BAT	uphold wallet>50 BAT

Send a one-time tip of 5 BAT to a verified pubs laurenwags.github.io
Confirmed response value 3 is shown correctly in 1.26.x

Scenario 15: Install 1.25.x and enable rewards and disable rewards (disable Ads and AC ) and then upgrade profile to 1.26.x

Install 1.25.x and enable rewards
Disable Ads and AC switches
Response value is displayed as 2 ( Less than 10 BAT (0-9), excluding grants) which is incorrect
Upgrade profile to 1.26.x
Response value is displayed as 1 (Rewards disabled) which is expected

Verified passed with

Brave | 1.26.47 Chromium: 91.0.4472.77&nbsp;(Official Build)&nbsp;beta&nbsp;(x86_64)
-- | --
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS | macOS Version 10.15.7 (Build 19H1030)

Verified test plan from brave/brave-core#8734

Confirmed the following values for Brave.Rewards.WalletBalance.2 in brave://local-state

`Brave.Rewards.WalletBalance.2` = `0`	`Brave.Rewards.WalletBalance.2` = `2`	`Brave.Rewards.WalletBalance.2` = `3`	`Brave.Rewards.WalletBalance.2` = `4`

Verified passed with

Brave	1.26.47 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision	1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS	Linux

Verified test plan from brave/brave-core#8734

Confirmed the following values for Brave.Rewards.WalletBalance.2 in brave://local-state

`Brave.Rewards.WalletBalance.2` = `0`	`Brave.Rewards.WalletBalance.2` = `2`	`Brave.Rewards.WalletBalance.2` = `3`	`Brave.Rewards.WalletBalance.2` = `4`

GeetaSarvadnya · 2021-05-28T13:18:28Z

@iefremov @emerick Looks like it's a common rewards library fix that is shared by both Desktop and Android, I hope this fix is applicable for Android also

@srirambv Looks like this issue is appearing in Android also, have you seen this issue while testing P3A rewards on Android?

GeetaSarvadnya · 2021-06-04T07:43:33Z

Verified Android GPS version 1.25.x, the issue persists on Android also. This issue #8296 might have fixed the issue on android also. @srirambv please verify the issue on Android or let me know if you want me to verify the issue on 1.26.x. Thanks!

srirambv · 2021-06-15T10:40:21Z

Verification passed on OnePlus 6T with Android 10 running 1.26.59 x64 Beta Build

`Brave.Rewards.WalletBalance.2 = 0`	`Brave.Rewards.WalletBalance.2 = 2`	`Brave.Rewards.WalletBalance.2 = 3`	`Brave.Rewards.WalletBalance.2 = 4`

srirambv added bug QA/Yes release-notes/exclude features/P3A labels Feb 18, 2020

srirambv mentioned this issue Feb 18, 2020

Fix P3A metrics reporting wallet state #7633

Closed

rebron assigned iefremov Feb 18, 2020

rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 18, 2020

bsclifton added the OS/Desktop label Sep 14, 2020

bsclifton unassigned iefremov Apr 30, 2021

bsclifton changed the title ~~[P3A] Incorrect value set for WalletBalance [Follow up to #7633]~~ [P3A] Incorrect value set for Q12 / WalletBalance (Brave.Rewards.WalletBalance.2) Apr 30, 2021

bsclifton mentioned this issue Apr 30, 2021

Properly implement rewards/ads related P3A questions #13996

Closed

bsclifton added the feature/rewards label Apr 30, 2021

emerick self-assigned this Apr 30, 2021

emerick modified the milestone: tia check May 2, 2021

emerick mentioned this issue May 6, 2021

Fix WalletBalance P3A responses brave/brave-core#8734

Merged

24 tasks

emerick closed this as completed in brave/brave-core#8734 May 12, 2021

emerick added this to the 1.26.x - Nightly milestone May 12, 2021

GeetaSarvadnya added the QA/Test-All-Platforms label May 28, 2021

GeetaSarvadnya added the QA Pass-Win64 label May 28, 2021

LaurenWags added QA Pass-macOS QA Pass-Linux labels Jun 1, 2021

GeetaSarvadnya added the OS/Android Fixes related to Android browser functionality label Jun 4, 2021

srirambv added the QA Pass - Android ARM label Jun 15, 2021

rillian mentioned this issue Jul 18, 2022

P3A - Wallet balance answer value isn't updated correctly in logs #7235

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[P3A] Incorrect value set for Q12 / WalletBalance (Brave.Rewards.WalletBalance.2) #8296

[P3A] Incorrect value set for Q12 / WalletBalance (Brave.Rewards.WalletBalance.2) #8296

srirambv commented Feb 18, 2020

LaurenWags commented Feb 18, 2020

GeetaSarvadnya commented Jun 4, 2020 •

edited

Loading

GeetaSarvadnya commented May 28, 2021 •

edited by LaurenWags

Loading

GeetaSarvadnya commented May 28, 2021

GeetaSarvadnya commented Jun 4, 2021 •

edited

Loading

srirambv commented Jun 15, 2021

[P3A] Incorrect value set for Q12 / WalletBalance (Brave.Rewards.WalletBalance.2) #8296

[P3A] Incorrect value set for Q12 / WalletBalance (Brave.Rewards.WalletBalance.2) #8296

Comments

srirambv commented Feb 18, 2020

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

LaurenWags commented Feb 18, 2020

GeetaSarvadnya commented Jun 4, 2020 • edited Loading

GeetaSarvadnya commented May 28, 2021 • edited by LaurenWags Loading

GeetaSarvadnya commented May 28, 2021

GeetaSarvadnya commented Jun 4, 2021 • edited Loading

srirambv commented Jun 15, 2021

GeetaSarvadnya commented Jun 4, 2020 •

edited

Loading

GeetaSarvadnya commented May 28, 2021 •

edited by LaurenWags

Loading

GeetaSarvadnya commented Jun 4, 2021 •

edited

Loading