Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recurring flag from DoTip in rewards service in lib #8403

Closed
NejcZdovc opened this issue Feb 25, 2020 · 1 comment · Fixed by brave/brave-core#4870
Closed

Remove recurring flag from DoTip in rewards service in lib #8403

NejcZdovc opened this issue Feb 25, 2020 · 1 comment · Fixed by brave/brave-core#4870

Comments

@NejcZdovc
Copy link
Contributor

DoTip has flag for recurring. Because we have SaveRecurringTip api now, we should remove this flag and in service call SaveRecurringTip if recurring. This should clear things

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 1, 2020

Verification passed on

Brave 1.7.79 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Before changing the recurring tip value in panel
image
image

After changing the recurring tip value in panel
image
image

  • Verified that the contribution amount for recurring tip is displayed correctly in Panel, brave://rewards settings page as well as in contribution_info and contribution_info_publisher tables

Verified passed with

Brave 1.7.81 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Before changing the recurring tip value in panel
Screen Shot 2020-04-01 at 3 00 30 PM
Screen Shot 2020-04-01 at 3 00 45 PM
Screen Shot 2020-04-01 at 3 02 06 PM

After changing the recurring tip value in panel
Screen Shot 2020-04-01 at 3 03 09 PM
Screen Shot 2020-04-01 at 3 03 27 PM
Screen Shot 2020-04-01 at 3 03 56 PM

  • Verified that the contribution amount for recurring tip is displayed correctly in Panel, brave://rewards settings page as well as in contribution_info and contribution_info_publishers tables

Verification passed on

Brave 1.7.81 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

Before changing the recurring tip value in panel
image

After changing the recurring tip value in panel
image

Verified that the contribution amount for recurring tip is displayed correctly in Panel, brave://rewards settings page as well as in contribution_info and contribution_info_publisher tables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment