Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include failed contributions in monthly statement #8821

Closed
NejcZdovc opened this issue Mar 23, 2020 · 1 comment · Fixed by brave/brave-core#5028
Closed

Do not include failed contributions in monthly statement #8821

NejcZdovc opened this issue Mar 23, 2020 · 1 comment · Fixed by brave/brave-core#5028

Comments

@NejcZdovc
Copy link
Contributor

Description

Steps to Reproduce

  1. enable rewards
  2. claim grant
  3. do AC
  4. go to DB, go to contribution_info table and change step from -1 to -3

Actual result:

Contribution is shown in the monthly statement

Expected result:

Contribution should not be shown in monthly statement

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@LaurenWags
Copy link
Member

LaurenWags commented Mar 31, 2020

Verified passed with

Brave 1.7.79 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Monthly statement after successful AC:
Screen Shot 2020-03-31 at 10 38 51 AM
Screen Shot 2020-03-31 at 10 38 59 AM

Monthly statement after changing step value in contribution_info table:
Screen Shot 2020-03-31 at 10 40 19 AM
Screen Shot 2020-03-31 at 10 40 26 AM

Note - as mentioned in brave/brave-core#5028 (comment), confirmed with @NejcZdovc that the Auto Contribute will still show in the summary (upper right corner) of monthly statement as well as on panel and brave://rewards summaries.

Verification passed on

Brave 1.7.79 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Monthly statement after successful AC:
image
image

Monthly statement after changing step value in contribution_info table:
image
image

Rewards summary in brave://rewards settings page and BR Panel remains as it is
image

Verification passed on

Brave 1.7.81 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

Monthly statement after successful AC:
image
image

Monthly statement after changing step value in contribution_info table:
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment