Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandwidth Savings Predictor changes for Chromium 83. #9176

Closed
mkarolin opened this issue Apr 13, 2020 · 1 comment · Fixed by brave/brave-core#5437
Closed

Bandwidth Savings Predictor changes for Chromium 83. #9176

mkarolin opened this issue Apr 13, 2020 · 1 comment · Fixed by brave/brave-core#5437
Assignees
Labels

Comments

@mkarolin
Copy link
Contributor

This Chromium change (landing in Cr83) has removed

  // The first time the page is considered 'interactive'. This is determined
  // using heuristics based on main thread and network activity. Time delta is
  // relative to navigation_start.
  mojo_base.mojom.TimeDelta? interactive;

value from struct InteractiveTiming.

Underlying Chromium issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1055806

A commit in brave/brave-core#5102 (WIP for upgrade to Cr83) named InteractiveTiming.interactive was removed from page load metrics. removes direct use of the field from the bandwidth savings predictor, but doesn't touch the model components/brave_perf_predictor/python/resources, which uses the field.

This is a followup issue to determine what needs to happen in the model (or if the interactive field needs to be restored in the code).

cc: @bsclifton

@anthonypkeane anthonypkeane added OS/Android Fixes related to Android browser functionality OS/Desktop labels Apr 27, 2020
AndriusA pushed a commit to brave/brave-core that referenced this issue May 1, 2020
AndriusA pushed a commit to brave/brave-core that referenced this issue May 4, 2020
AndriusA pushed a commit to brave/brave-core that referenced this issue May 6, 2020
AndriusA pushed a commit to brave/brave-core that referenced this issue May 12, 2020
@bsclifton bsclifton added this to the 1.10.x - Nightly milestone May 12, 2020
@bsclifton
Copy link
Member

Setting missing milestone to 1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants