Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandwidth improvements #5437

Merged
merged 7 commits into from
May 12, 2020
Merged

Bandwidth improvements #5437

merged 7 commits into from
May 12, 2020

Conversation

AndriusA
Copy link

@AndriusA AndriusA commented May 1, 2020

Resolves brave/brave-browser#8969
Resolves brave/brave-browser#8186
Resolves brave/brave-browser#9176

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@AndriusA AndriusA force-pushed the bandwidth-improvements branch 2 times, most recently from 85f559a to d6d6b6b Compare May 4, 2020 12:58
@AndriusA
Copy link
Author

AndriusA commented May 4, 2020

CI shows build passed (after retries, probably why not reflected here)

Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, as long as android CI is green

@AndriusA
Copy link
Author

CI only shows one known error failure and only on macos:

[559/559] BraveRewardsBrowserTest.NotVerifiedWallet (6346 ms)
15:49:44  1 test failed:
15:49:44      BraveRewardsBrowserTest.NotVerifiedWallet (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2356)

@AndriusA AndriusA merged commit a9989e4 into master May 12, 2020
@AndriusA AndriusA deleted the bandwidth-improvements branch May 12, 2020 16:25
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

js code lgtm 👍

@bsclifton bsclifton added this to the 1.10.x - Nightly milestone May 12, 2020
@bsclifton
Copy link
Member

Set milestone to 1.10; looks like we forgot to set it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants