Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget context menu on NTP is behind top sites #9267

Closed
cezaraugusto opened this issue Apr 16, 2020 · 2 comments · Fixed by brave/brave-core#5297
Closed

Widget context menu on NTP is behind top sites #9267

cezaraugusto opened this issue Apr 16, 2020 · 2 comments · Fixed by brave/brave-core#5297
Assignees
@ryanml
Labels
feature/new-tab OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude
Milestone
1.8.x - Release

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Apr 16, 2020 •
edited by ryanml
Loading

See screenshot

Screen Shot 2020-04-16 at 12 44 57

Test Plan

  1. Launch Brave
  2. Accumulate some top sites
  3. Click the ellipsis menu in the top right corner of the top sites widget
  4. Ensure that widget menu lays over the top site tiles, and does not clip behind.

cc @ryanml
@cezaraugusto cezaraugusto added feature/new-tab regression priority/P3 The next thing for us to work on. It'll ride the trains. labels Apr 16, 2020
@cezaraugusto
Copy link
Contributor Author

Set as p3 since it's a regression

@ryanml ryanml self-assigned this Apr 20, 2020
@ryanml ryanml added this to the 1.9.x - Nightly milestone Apr 20, 2020
ryanml added a commit to brave/brave-core that referenced this issue Apr 20, 2020
@ryanml
Fixes brave/brave-browser#9267 - Upping z-index for widget menus
962b045
@ryanml ryanml added the QA/Yes label Apr 20, 2020
@ryanml ryanml mentioned this issue Apr 20, 2020
Merged
32 tasks
@LaurenWags LaurenWags mentioned this issue Apr 22, 2020
Closed
This was referenced Apr 22, 2020
Merged
Merged
@LaurenWags LaurenWags mentioned this issue Apr 23, 2020
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Apr 27, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave 1.8.84 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified test plan from description.
  • Confirmed for varying window sizes:

Screen Shot 2020-04-27 at 7 39 14 AM

Screen Shot 2020-04-27 at 7 38 48 AM

Screen Shot 2020-04-27 at 7 39 00 AM

Verification passed on

Brave 1.8.84 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from the description.
  • Confirmed for varying window sizes:

image

image

image

Verification passed on

Brave 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Ubuntu 18.04 LTS
  • Verified test plan from the description.
  • Confirmed for varying window sizes:
    image
    image
    image

@btlechowski btlechowski mentioned this issue Apr 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
feature/new-tab OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging a pull request may close this issue.

Fixing widget context menu for top site tiles brave/brave-core
7 participants
@kjozwiak @cezaraugusto @bsclifton @ryanml @LaurenWags @btlechowski @GeetaSarvadnya