Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing widget context menu for top site tiles (uplift to 1.8.x) #5328

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Fixing widget context menu for top site tiles (uplift to 1.8.x) #5328

merged 1 commit into from
Apr 23, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 22, 2020 •
edited by kjozwiak
Loading

Uplift of #5297
Fixes brave/brave-browser#9267

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Apr 22, 2020
@brave-builds brave-builds added this to the 1.8.x - Release milestone Apr 22, 2020
@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron and srirambv April 22, 2020 23:30
@bsclifton bsclifton added the CI/skip Do not run CI builds (except noplatform) label Apr 22, 2020
@bsclifton
Copy link
Member

Marked as CI/skip since this is a small CSS only change. Build/tests/etc wouldn't affect this and we've tested on Nightly

@kjozwiak
Copy link
Member

QA verified #5297 on Nightly as per #5297 (comment).

kjozwiak
kjozwiak approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.8.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 5e724ae into 1.8.x Apr 23, 2020
@kjozwiak kjozwiak deleted the pr5297_fix-9267_1.8.x branch April 23, 2020 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @bsclifton @kjozwiak @brave-browser-releases