-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoscroll functionality for Linux / Mac #959
Comments
I tried the above AutoScroll extension, where in the reviews a comment led me to this thread. With the Cases where this does not work yet for me:
|
Please.. |
^ |
FYI also still experiencing this on macOS
|
Can that ticket be used to ask for auto-scrolling in Android too? |
EDIT: for anyone wondering, use the Smoothscroll extension instead of the one mentioned above to increase the scroll speed on Linux. If you want to closely mirror Firefox's scrolling, try these settings: 100 400 999 20 10 50. Then, disable the autoscroll that the extension provides in the settings and follow the steps in this guide to enable native linux autoscroll. Note that you will have to redo this process every time you update your browser, so you might want to write a script to do it automatically. |
I’m surprised this isn’t still a thing... Firefox had this feature for years for Linux and macOS. Although the chromium extension does address the issue to some degree, it’s just not as good and smooth as having a native solution. I hope you guys implement this; as far I know, no chromium fork has ever implemented auto-scroll on Linux and macOS. |
I investigated this further and found this very interesting bug report for Chromium: Everyone in that bug report as well on here wants Autoscroll to be a thing. If we look at "Comment 15," the user claims that he was able to implement Autoscroll for Linux by just changing two files, and he only changed around 35 lines of code. "I don't get what the problem is. Every other browser on Linux has this functionality with no argument saying it's "not linux behavior" - which doesn't make sense to me. It seems like we were getting towards a solution here only to have it unceremoniously chopped. It's strange and inconsistent that the Linux side of the browser operates differently to the other platforms. I'm sure creating the browser in the first place was a whole lot harder then introducing a bloody autoscroll function. If it's hard to implement on the linux platform but apparently not on others then maybe the browser was designed wrong in the first place?" The sad thing is that this affects every Chromium Fork and every Electron app. Further, the Chromium devs never gave a good reason as to why this can't be implemented. They already almost did it; it just needed a bit more work to make sure it works on macOS and doesn't mess with other OS's. Overall this whole situation is really weird. I can't believe I have to be here writing about this wherefrom the looks of this could've been done in a matter of hours or a few days way back then or now. Chromium will most likely never make Autoscroll for Linux and macOS a reality. So I'm kindly asking the Brave team to look into this and be the first Chromium fork to have this feature. |
Another update. It appears that in order to enable Auto Scroll you only have to remove the if statement from this file here: https://github.com/chromium/chromium/blob/b441bdf0cbb94fb47df3a500346664f0f8bc4551/third_party/blink/renderer/core/exported/web_view_impl.cc#L1813 I'm surprised this is still an issue. From the looks of it. This whole thing can be resolve by just making a toggle setting in the settings page that sets "RuntimeEnabledFeatures::SetMiddleClickAutoscrollEnabled" to true or false. Hey, @bsclifton please take a look at this. |
Seems like this file doesn't exist in Brave's repo? |
True, but it might just be in a different location or a different file is handling this behavior on Brave. I'm only aware of this code's existence on the Chromium. When using Brave Browser on Windows, you can still use Middle Click to Auto Scroll. |
I guess this is never going to get fixed. |
Brave Browser extends and patches but uses upstream Chromium. For changes, you should probably look into https://github.com/brave/brave-core |
Specifically a patch in https://github.com/brave/brave-core/tree/master/patches that modifies https://github.com/chromium/chromium/blob/main/third_party/blink/renderer/core/exported/web_view_impl.cc#L1797-L1799 might do more of what you guys want. I don't have the skills to implement and test this, but it does seem possible to implement as a pull request. |
I removed the if statement and I can confirm that this solves this issue. I tested this on Arch Linux and autoscroll seems to work out of the box |
After wasting several hours on figuring out how to build brave-browser from source and compiling it, I can also confirm that middle click autoscroll works fine on Arch Linux. I've been actively using browser with this feature enabled for 2 days already, and encountered no issues so far. |
Tested this wrapper with updating directly from Brave itself ("Help" -> "About Brave") and everything seem to work as usual so no additional steps are required 😄 Note: If you use |
Hello, everyone. I'm going to plumb the blink preference to the brave::/flags page so that the feature can be tested more easily. It seems to work well on Mac for me. If it turns out to work well on the both platforms, we could move it to brave://settings page later. |
Verified with
Verified test plan from brave/brave-core#21874 (comment). Enabled the flag and relaunched: Confirmed after clicking the mouse middle button the cursor changed to an arrow and I could scroll up/down by moving the mouse. 1.64.mov |
Verified with
Verified test plan from brave/brave-core#21874 (comment). Enabled the flag and relaunched: Confirmed after clicking the mouse middle button the cursor changed to an arrow and I could scroll up/down by moving the mouse: arm64.mov |
Verification
Verified test plan from brave/brave-core#21874 (comment). Confirmed after clicking the mouse middle button the cursor changed to an arrow and I could scroll up/down by moving the mouse:2024-03-15_12h38_57.mp4 |
Carried over from brave/browser-laptop#3007
@JaneSmith mentions that the extension linked to has a bad implementation. The functionality desired is what is present in Firefox
The text was updated successfully, but these errors were encountered: