Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose "MiddleButtonAutoscroll" runtime feature to brave://flags #21874

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

sangwoo108
Copy link
Contributor

@sangwoo108 sangwoo108 commented Feb 2, 2024

This feature is disabled on Linux and MacOS. But as per a feature request, it's worth trying to enable it on those platforms.

Resolves brave/brave-browser#959
Resolves brave/brave-browser#15576

On Mac

Screen.Recording.2024-02-02.at.1.25.06.PM.mov

On Linux

Screen.Recording.2024-02-04.at.10.46.14.AM.mov

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Enable brave://flags#middle-button-autoscroll on Mac and Linux
  • Click middle button on web page's empty space
  • See if cursor is changed to arrow
  • When you move mouse upward/downward, page will keep scrolling.

This feature is disabled on Linux and MacOS. But as per a feature request,
it's worth trying to enable it on those platforms.
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Feb 2, 2024
@sangwoo108 sangwoo108 marked this pull request as ready for review February 4, 2024 01:48
@sangwoo108 sangwoo108 requested review from a team as code owners February 4, 2024 01:48
@sangwoo108 sangwoo108 merged commit e1546dd into master Feb 6, 2024
23 checks passed
@sangwoo108 sangwoo108 deleted the sko/autoscroll branch February 6, 2024 13:02
@github-actions github-actions bot added this to the 1.64.x - Nightly milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middle click/scroll function doesn't work with Linux version Autoscroll functionality for Linux / Mac
2 participants