Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Estimated" from bandwidth saved and time saved #9838

Closed
karenkliu opened this issue May 19, 2020 · 5 comments · Fixed by brave/brave-core#5630
Closed

Remove "Estimated" from bandwidth saved and time saved #9838

karenkliu opened this issue May 19, 2020 · 5 comments · Fixed by brave/brave-core#5630

Comments

@karenkliu
Copy link

karenkliu commented May 19, 2020

Description

Remove "Estimated" from Brave Stats on NTP.

Steps to Reproduce

  1. Open a new tab page

Actual result:

Screen Shot 2020-05-19 at 11 33 58 AM

Expected result:

Screen Shot 2020-05-19 at 11 34 21 AM

Reproduces how often:

Easily

Brave version (brave://version info)

Nightly

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? no
  • Can you reproduce this issue with the dev channel? no
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@bsclifton bsclifton added the needs-text-change This change requires some careful wording. label May 21, 2020
@rebron
Copy link
Collaborator

rebron commented May 29, 2020

@0xedward Can you grab this one too. Maybe as part of this pr brave/brave-core#5630

@0xedward
Copy link

@rebron Sure, looking into it now

0xedward added a commit to 0xedward/brave-core that referenced this issue May 30, 2020
Change "Estimated bandwidth saved" to "Bandwidth saved"
Change "Estimated time saved" to "Time saved"

Fix brave/brave-browser#9838
@0xedward
Copy link

While updating the text from "Estimated bandwidth saved" to "Bandwidth saved", I noticed the attribute name for that message is IDS_BRAVE_NEW_TAB_ESTIMATED_BANDWIDTH_SAVED. Is that something we want to replace with IDS_BRAVE_NEW_TAB_BANDWIDTH_SAVED and update all current instances of IDS_BRAVE_NEW_TAB_ESTIMATED_BANDWIDTH_SAVED to reflect that change?

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 8, 2020

Verification passed on


Brave | 1.10.86 Chromium: 83.0.4103.61 (Official Build) (64-bit)
-- | --
Revision | 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Verification PASSED on macOS 10.15.5 x64 Catalina using the following build:

Brave | 1.10.86 Chromium: 83.0.4103.61 (Official Build) (64-bit)
-- | --
Revision | 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS | macOS Version 10.15.5 (Build 19F101)
  • ensured that Estimated was removed from Bandwidth saved under NTP
  • ensured that stats under NTP are being updated when visiting websites
  • ensured that restarting the browser doesn't reset the NTP stats
  • ensured that disabling/enabling stats on NTP works without any issues
  • ensured upgrading from 1.9.76 --> 1.10.86 didn't cause any issues
  • ran into [Desktop] NTP Estimated bandwidth saved stat is not shown on clean install #9993 while going through the above

Screen Shot 2020-06-08 at 11 09 24 AM

Verification passed on

Brave 1.10.86 Chromium: 83.0.4103.61 (Official Build) (64-bit)
Revision 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS Ubuntu 18.04 LTS

image
Polish
image

@rebron
Copy link
Collaborator

rebron commented Jun 13, 2020

While updating the text from "Estimated bandwidth saved" to "Bandwidth saved", I noticed the attribute name for that message is IDS_BRAVE_NEW_TAB_ESTIMATED_BANDWIDTH_SAVED. Is that something we want to replace with IDS_BRAVE_NEW_TAB_BANDWIDTH_SAVED and update all current instances of IDS_BRAVE_NEW_TAB_ESTIMATED_BANDWIDTH_SAVED to reflect that change?

@0xedward No need to change above. That can stay as is.

Thanks again for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment