-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Brave Stat text on New Tab Page from "Ads and Trackers blocked" to "Trackers & ads blocked" #5630
Conversation
ebe47ea
to
ce30c61
Compare
…" to "Trackers & ads blocked" Fix brave/brave-browser#9692
ce30c61
to
dd88967
Compare
LGTM! @0xedward would you be able to take on brave/brave-browser#9838 in this same pull request? 😄 |
@bsclifton Sure thing! I'm working on it now |
Change "Estimated bandwidth saved" to "Bandwidth saved" Change "Estimated time saved" to "Time saved" Fix brave/brave-browser#9838
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiled on Windows; changes LGTM!
@mkarolin can you check out also just to make sure I didn't miss something? Change shouldn't match anything we're manually doing search/replaces for (ex: Google => Brave) so I think we're good to go. Could be great to accept before we do Chromium 83 translations 😄
Marked as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @bsclifton I don't think this file goes through the branding replacement script since this one is fully controlled by us.
Thanks for the contribution, @0xedward 😄! I'll try and circle back on your other ones now |
Thanks @0xedward Excellent! @mkarolin @bsclifton Just to confirm that we do want this for 1.10.x as the stat will be updated then. |
Update Brave Stat text on New Tab Page from "Ads and Trackers blocked" to "Trackers & ads blocked"
Resolves brave/brave-browser#9692
Resolves brave/brave-browser#9838
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.