Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The color of "Background images" toggle text in brave://settings/newTab is wrong. #9949

Closed
mkarolin opened this issue May 26, 2020 · 1 comment · Fixed by brave/brave-core#5664

Comments

@mkarolin
Copy link
Contributor

Description

The color of "Background images" toggle text appears to be different from other toggles.
In the design (see #8760) all toggles are the same color.

image

Steps to Reproduce

  1. Open Brave
  2. Navigate to brave://settings/newTab
  3. See the colors of the toggles text

Actual result:

"Background images" text color is different from other toggles text

Expected result:

"Background images" text color is the same as the other toggles text

Reproduces how often:

100%

Brave version (brave://version info)

1.9.72, 1.11.28

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@LaurenWags
Copy link
Member

LaurenWags commented Jun 16, 2020

Verified passed with

Brave 1.11.65 Chromium: 83.0.4103.97 (Official Build) dev (64-bit)
Revision 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS macOS Version 10.14.6 (Build 18G3020)
  • Reproduced issue on 1.10.90

Screen Shot 2020-06-16 at 9 47 05 AM

  • Confirmed STR from description

Screen Shot 2020-06-16 at 9 47 13 AM


Verification passed on

Brave | 1.11.68 Chromium: 83.0.4103.106 (Official Build) dev (64-bit)
-- | --
Revision | ce7134bb3d95141cd18f1e65772a4247f282d950-refs/branch-heads/4103@{#694}
OS | Windows 10 OS Version 1903 (Build 18362.30)

  • Reproduced issue on 1.10.90
    image
  • Confirmed STR from description
    image

Verified passed with

Brave	1.11.80 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Linux
  • Verified STR from description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment