Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes color of "Background images" toggle text in Settings (1.10.x). #5665

Closed
wants to merge 1 commit into from

Conversation

mkarolin
Copy link
Collaborator

In the New Tab Page settings.

Fixes brave/brave-browser#9949
Uplift from: #5664

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Fixes color of "Background images" toggle text in Settings.
@mkarolin mkarolin added the CI/skip Do not run CI builds (except noplatform) label May 27, 2020
@mkarolin mkarolin added this to the 1.10.x - Beta milestone May 27, 2020
@mkarolin mkarolin requested a review from a team May 27, 2020 01:56
@mkarolin mkarolin self-assigned this May 27, 2020
@mkarolin
Copy link
Collaborator Author

CI will not be useful for this fix, so applied CI/Skip.

@mkarolin mkarolin changed the title Fixes color of "Background images" toggle text in Settings. Fixes color of "Background images" toggle text in Settings (1.10.x). May 27, 2020
@LaurenWags
Copy link
Member

@mkarolin per discussion with @brave/uplift-approvers we've decided not to uplift this item at this time. Please let me know if you have any concerns.

@LaurenWags LaurenWags closed this May 29, 2020
@bsclifton bsclifton removed this from the 1.10.x - Beta milestone May 29, 2020
@bsclifton bsclifton deleted the maxk-fix-setting-text-color-1.10.x branch May 29, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants