Merge pull request #75 from brave/fix_shield_icon_logic

Only show shield icon as disabled when the shield is explicitly blocked.
brave · Oct 15, 2018 · 27410fd · 27410fd
2 parents 9e6c43e + 1a60fd8
commit 27410fd
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/app/background/reducers/shieldsPanelReducer.ts b/app/background/reducers/shieldsPanelReducer.ts
@@ -39,7 +39,7 @@ const updateShieldsIconImage = (state: State) => {
   const tab: Tab = state.tabs[tabId]
   if (tab) {
     const url: string = tab.url
-    const isShieldsActive: boolean = state.tabs[tabId].braveShields === 'allow'
+    const isShieldsActive: boolean = state.tabs[tabId].braveShields !== 'block'
     setIcon(url, tabId, isShieldsActive)
   }
 }