3rd party fingerprinting protection #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrliou
force-pushed
the
3rd_party_fingerprinting
branch
2 times, most recently
from
db14524
to
979cc0e
Compare
|
I have wrote a browser test for this, will push it later after some refactoring. |
yrliou
force-pushed
the
3rd_party_fingerprinting
branch
2 times, most recently
from
c2ae4c5
to
3febdaa
Compare
|
Is there a way to reduce the inline code without increasing the number of patches too significantly? |
yrliou
force-pushed
the
3rd_party_fingerprinting
branch
2 times, most recently
from
f8f2689
to
35db990
Compare
bbondy
previously approved these changes
Apr 5, 2018
yrliou
force-pushed
the
3rd_party_fingerprinting
branch
from
35db990
to
1fda5a0
Compare
bbondy
approved these changes
Apr 5, 2018
bbondy
pushed a commit
that referenced
this pull request
Feb 18, 2019
Only show shield icon as disabled when the shield is explicitly blocked.
NejcZdovc
added a commit
that referenced
this pull request
Feb 25, 2019
Add support for VLOG to help reduce noise in logs for INFO
tmancey
pushed a commit
that referenced
this pull request
Feb 27, 2019
* Initial commit * Added SetTimer and OnTimer * Added missing #include for wallet_info data structure * Added catalog issuers data structure * Added OnCatalogIssuersChanged * Added OnTimer * Changed LOG to BLOG due to conflicts with base:: * wip, builds * build w/ all class code * port steps 1-5 * match server regex update * Integration for brave-core * Temporarily use std::cout instead of BLOG due to build issues * Resolve linking issue with IsReadyToShowAds * Only start filling confirmations, retrieving payments and cashing in payments once initialized * Revert "Temporarily use std::cout instead of BLOG due to build issues" This reverts commit 7baad78. * Refactor to use callbacks * Improve logging to help diagnose issues * Confirmations fails to initialize when creating a new wallet (#42) * Improve logging to help diagnose issues (#43) * Confirmations fails to initialize when creating a new wallet (#44) * Ads Serve failures should retry (#45) * Resolves initiating profile DCHECK failure (#47) * Improve logging to help diagnose issues (#48) * Fix unit test build errors #53 (#54) * Changes to how unblind and BatchDLEQProof::verify are being called in challenge-bypass-ristretto-ffi * Decouple refill tokens * Decouple redeem token * Decouple payout tokens * Added Ads Serve helper * Decouple security into security helper * Updated static values * Updated BUILD.gn * Refactor ConfirmationsImpl to use decoupled logic * Added string helper * Remove unused HappyHTTP dependency * Add support for _is_production flag to choose between production and staging environments * refactor dependencies * Decoupled unblinded tokens and url request builder for unit tests * Resolve compiler errors and decouple logic in preparation for unit testing * Added unit tests * Fix build for Windows/Linux * Fix linter errors * Confirmations should not be initialized if the wallet is invalid * Removed unecessary boolean logic * Return if wallet info is not ready * Fix build error * Fix header files * Fix unit tests * Remove redundant #include for unblinded_tokens.h * Fixed unit test #include paths * Revert "Remove redundant #include for unblinded_tokens.h" This reverts commit 35f055e82f0a22428c600360a75336351f34458d. * Remove redundant #include for unblinded_tokens.h * Fixed unit test #include paths * Refactor new to unique_ptr for unit tests * Remove logging for unit tests * Resolved lint error * Added README.md * Fixed linter errors * Fix Linux and Windows build errors * Resolve logging issue with wallet info * Add support for VLOG to help reduce noise in logs for INFO * Added ability to retrieve transaction history * Fixed build error and refactored ctime to use base::Time * Redeem tokens when notifications are viewed * Update client when transaction history changes * Reduced maximum persisted unblinded tokens from 100 to 50 Reduced maximum persisted unblinded tokens from 100 to 50 to reduce the chance that the server fails to generate the tokens before the next request. If the server still does not generate the tokens in time we retry after 15 seconds. * Updated Copyright in BUILD.gn * Updated README.md * Revert "Merge pull request #75 from brave-intl/issues/52" This reverts commit fc7de34, reversing changes made to 211e767. * Fixed unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: brave/brave-browser#126
requires: brave/brave-extension#15
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
https://audiofingerprint.openwpm.com/ AudioContext/AudioBuffer fingerprinting methods are blocked only for block all fingerprinting option.
https://jsfiddle.net/bkf50r8v/13/ 5 fingerprinting methods blocked for both block all and block 3rd party options.
Reviewer Checklist: