cr83 followup: fixes notarization on MacOS.

Fixes brave/brave-browser#9971 - Restored provisioning profile param in GetBraveSigningConfig. - Updated notarization script to not pass `development` param to GetBraveSigningConfig.
brave · May 27, 2020 · d7404b6 · d7404b6
1 parent 1cac237
commit d7404b6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/build/mac/notarize_dmg_pkg.py b/build/mac/notarize_dmg_pkg.py
@@ -67,7 +67,7 @@ def run_spctl_assess(self):
 
         config_class = DevelopmentCodeSignConfig
 
-    config_class = GetBraveSigningConfig(config_class, development, mac_provisioning_profile)
+    config_class = GetBraveSigningConfig(config_class, mac_provisioning_profile)
     return config_class(*config_args)
 
 

diff --git a/script/signing_helper.py b/script/signing_helper.py
@@ -120,7 +120,7 @@ def AddBravePartsForSigning(parts, config):
     return parts
 
 
-def GetBraveSigningConfig(config_class):
+def GetBraveSigningConfig(config_class, mac_provisioning_profile=None):
     class ConfigNonChromeBranded(config_class):
 
         @staticmethod
@@ -129,9 +129,13 @@ def is_chrome_branded():
 
     config_class = ConfigNonChromeBranded
 
-    # Retrieve provisioning profile exported by build/mac/sign_app.sh
-    # If not set, then it's development config.
-    provisioning_profile = os.environ['MAC_PROVISIONING_PROFILE']
+    if mac_provisioning_profile is not None:
+        provisioning_profile = mac_provisioning_profile
+    else:
+        # Retrieve provisioning profile exported by build/mac/sign_app.sh
+        provisioning_profile = os.environ['MAC_PROVISIONING_PROFILE']
+
+    # If provisioning_profile is not set, then it's development config.
     if not len(provisioning_profile):
         return config_class