Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cr83 followup: notarization script on MacOS fails. #9971

Closed
mkarolin opened this issue May 27, 2020 · 0 comments · Fixed by brave/brave-core#5674
Closed

cr83 followup: notarization script on MacOS fails. #9971

mkarolin opened this issue May 27, 2020 · 0 comments · Fixed by brave/brave-core#5674
Assignees
@mkarolin
Labels
dev-concern QA/No release-notes/exclude
Milestone
1.10.x - Release

Comments

@mkarolin
Copy link
Contributor

brave/brave-core@e96d4d4 changed the signature of GetBraveSigningConfig, but notarize_dmg_pkg.py that also calls it has not been taken into account.
@mkarolin mkarolin self-assigned this May 27, 2020
mkarolin added a commit to brave/brave-core that referenced this issue May 27, 2020
@mkarolin
cr83 followup: fixes notarization on MacOS.
d7404b6 
Fixes brave/brave-browser#9971

- Restored provisioning profile param in GetBraveSigningConfig.
- Updated notarization script to not pass `development` param to GetBraveSigningConfig.
This was referenced May 27, 2020
Merged
Merged
@mkarolin mkarolin added this to the 1.11.x - Nightly milestone May 28, 2020
@mkarolin mkarolin mentioned this issue Jun 4, 2020
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
dev-concern QA/No release-notes/exclude
Projects
None yet
Milestone
1.10.x - Release
Development

Successfully merging a pull request may close this issue.

cr83 followup: fixes notarization on MacOS. brave/brave-core
1 participant
@mkarolin