Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get region list from vpn service to webui #10066

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Get region list from vpn service to webui #10066

merged 1 commit into from
Oct 8, 2021

Conversation

nullhook
Copy link
Contributor

@nullhook nullhook commented Sep 13, 2021

Resolves brave/brave-browser#18055
Resolves brave/brave-browser#18402

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions

@nullhook nullhook force-pushed the vpn_region_list branch 3 times, most recently from f4485ff to 077ea03 Compare September 14, 2021 18:54
@nullhook
Copy link
Contributor Author

nullhook commented Sep 14, 2021

This is failing because storybook's webpack config isn't aware of gen/ path.

await for this PR to be merged: #10056

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@nullhook nullhook added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Sep 15, 2021
@nullhook nullhook removed CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows CI/skip-ios Do not run CI builds for iOS labels Sep 23, 2021
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@nullhook nullhook force-pushed the vpn_region_list branch 2 times, most recently from a6e21c3 to 6b8ca8f Compare September 30, 2021 15:45
Comment on lines +1 to +10
export interface Region {
continent: string
name: string
namePretty: string
}
export interface RegionState {
all?: Array<Region>,
current?: Region,
hasError: boolean
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why we're adding new types when these seem to be in .mojom and now you're pulling in mojom types directly to './panel_browser_api'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are state types and then there are mojom types. The mojom types will be directly pulled from m.js file in another PR and I will move all state types to another folder dir.

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarCloud failure is false positive

@petemill
Copy link
Member

petemill commented Oct 8, 2021

Last macOS build got a timeout but we're ok to merge IMO as we've had several macOS successful builds - we did the rebuilds to fix linux via devops changes to run gn storybook targets, and now that's a success.

@petemill petemill merged commit 5e88641 into master Oct 8, 2021
@petemill petemill deleted the vpn_region_list branch October 8, 2021 06:19
@nullhook nullhook added this to the 1.32.x - Nightly milestone Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPN Panel is not launched [Desktop VPN] Get region list from the desktop service to webui
3 participants