-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get region list from vpn service to webui #10066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some questions
components/brave_vpn/resources/panel/components/select-region/index.tsx
Outdated
Show resolved
Hide resolved
components/brave_vpn/resources/panel/components/select-region/index.tsx
Outdated
Show resolved
Hide resolved
c798346
to
f4ea746
Compare
f4ea746
to
e5e05f1
Compare
f4485ff
to
077ea03
Compare
This is failing because storybook's webpack config isn't aware of await for this PR to be merged: #10056 |
f35fa1c
to
cfe363a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
cfe363a
to
07b02a3
Compare
07b02a3
to
0baa66c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
0baa66c
to
ee31d5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
a6e21c3
to
6b8ca8f
Compare
export interface Region { | ||
continent: string | ||
name: string | ||
namePretty: string | ||
} | ||
export interface RegionState { | ||
all?: Array<Region>, | ||
current?: Region, | ||
hasError: boolean | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering why we're adding new types when these seem to be in .mojom and now you're pulling in mojom types directly to './panel_browser_api'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are state types and then there are mojom types. The mojom types will be directly pulled from m.js file in another PR and I will move all state types to another folder dir.
6b8ca8f
to
6a1393e
Compare
c3cc3f9
to
98f3f42
Compare
98f3f42
to
d66ebdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarCloud failure is false positive
Last macOS build got a timeout but we're ok to merge IMO as we've had several macOS successful builds - we did the rebuilds to fix linux via devops changes to run gn storybook targets, and now that's a success. |
Resolves brave/brave-browser#18055
Resolves brave/brave-browser#18402
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: