Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed vpn panel is not launched #10288

Closed
wants to merge 1 commit into from
Closed

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Sep 28, 2021

fix brave/brave-browser#18402

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@simonhong simonhong self-assigned this Sep 28, 2021
@@ -4,6 +4,7 @@ import MainPanel from './components/main-panel'
import ErrorPanel from './components/error-panel'
import apiProxy from './vpn_panel_api_proxy.js'
import { ConnectionState } from './types/connection_state'
import { PurchasedState } from './types/purchased_state'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think instead of importing here, we can import the brave_vpn::mojom::PurchasedState definition from mojom

Copy link
Member

@bsclifton bsclifton Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah - we might want @nullhook's PR- #10066

With this, we could basically import components/brave_vpn/resources/panel/api/panel_browser_api.ts and then we should be able to use the type like:

import { PurchasedState } from './api/panel_browser_api'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok. Then I think this fix could be added into @nullhook's PR and then merged together.

Copy link
Contributor

@nullhook nullhook Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd wait for my other PR to merge. Since it imports mojom types directly!

@simonhong simonhong changed the title Fixed panel is not launched Fixed vpn panel is not launched Sep 28, 2021
@simonhong
Copy link
Member Author

Closed because #10066 includes this fix.

@simonhong simonhong closed this Sep 28, 2021
@simonhong simonhong deleted the brave_vpn_fix_panel branch January 27, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPN Panel is not launched
3 participants