-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v8 patch to fix invalid WASM compilation. #10366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This patch should go away in cr96.
The issue is fixed, confirmed in Slack |
Verified
Before the fix, I couldn't reproduce this at-will, but I could see it quite often on Steps:
Confirmed after 20+ tries that I can no longer reproduce this 👍 |
Apply v8 patch to fix a random WASM compilation issue.
Resolves brave/brave-browser#18562
See also https://chromium-review.googlesource.com/c/v8/v8/+/3172761
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: