Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v8 patch to fix invalid WASM compilation. #10366

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Add v8 patch to fix invalid WASM compilation. #10366

merged 1 commit into from
Oct 5, 2021

Conversation

goodov
Copy link
Member

@goodov goodov commented Oct 5, 2021

Apply v8 patch to fix a random WASM compilation issue.

Resolves brave/brave-browser#18562
See also https://chromium-review.googlesource.com/c/v8/v8/+/3172761

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov requested a review from a team as a code owner October 5, 2021 15:12
@goodov goodov self-assigned this Oct 5, 2021
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This patch should go away in cr96.

@goodov goodov merged commit 30990cb into master Oct 5, 2021
@goodov goodov deleted the issues/18562 branch October 5, 2021 18:09
brave-builds pushed a commit that referenced this pull request Oct 5, 2021
brave-builds pushed a commit that referenced this pull request Oct 5, 2021
@goodov
Copy link
Member Author

goodov commented Oct 5, 2021

The issue is fixed, confirmed in Slack
https://bravesoftware.slack.com/archives/C7VLGSR55/p1633456669240100?thread_ts=1633436259.225700&cid=C7VLGSR55

@kjozwiak kjozwiak added this to the 1.32.x - Nightly milestone Oct 6, 2021
mkarolin added a commit that referenced this pull request Oct 6, 2021
This reverts commit 30990cb, reversing
changes made to 965f45a.

This was an upstream patch that was not available before cr96.

See #10366
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.32.46 Chromium: 94.0.4606.71 (Official Build) nightly (x86_64)
Revision 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS macOS Version 11.6 (Build 20G165)

Before the fix, I couldn't reproduce this at-will, but I could see it quite often on https://talk.brave.com, launching a call using Start free 1:1 call, reloading/interrupting it/clicking Back on the browser, etc. (basically forcing that screen to reload/execute again, on Creating meeting room... which is where it usually hangs).

Steps:

  1. new profile
  2. launch Brave
  3. load talk.brave.com
  4. enable Rewards via the BAT icon
  5. click on the Start free 1:1 call button
  6. next, did various reload, Back navigation, and interrupt scenarios, to try to get it to trigger

Confirmed after 20+ tries that I can no longer reproduce this 👍

mkarolin added a commit that referenced this pull request Oct 6, 2021
This reverts commit 30990cb, reversing
changes made to 965f45a.

This was an upstream patch that was not available before 95.0.4638.40

See #10366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasional renderer crash on WASM load/compilation step
4 participants