Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WDP App will never be undefined, resolve lint issue #10969

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

petemill
Copy link
Member

@petemill petemill commented Nov 10, 2021

Resolves brave/brave-browser#19332

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@petemill petemill self-assigned this Nov 10, 2021
@petemill petemill added the CI/skip Do not run CI builds (except noplatform) label Nov 10, 2021
@petemill petemill merged commit 5c36c0b into master Nov 10, 2021
@petemill petemill deleted the wdp-never-undefined branch November 10, 2021 02:15
@petemill petemill added this to the 1.34.x - Nightly milestone Nov 10, 2021
petemill added a commit that referenced this pull request Nov 10, 2021
WDP App will never be undefined, resolve lint issue
petemill added a commit that referenced this pull request Nov 10, 2021
WDP App will never be undefined, resolve lint issue
kjozwiak added a commit that referenced this pull request Nov 11, 2021
kjozwiak added a commit that referenced this pull request Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS Lint fails for webDiscoveryProject
2 participants