refactor ntp to use brave-ui #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allow us to have a better view of the front-end architecture and split interests between files
bsclifton
reviewed
Jan 14, 2019
| @@ -73,7 +73,7 @@ export const getGridSites = (state: NewTab.State, checkBookmarkInfo?: boolean) = | |||
| gridSites.forEach((gridSite: NewTab.Site) => { | |||
| gridSite.letter = getLetterFromSite(gridSite) | |||
| gridSite.thumb = `chrome://thumb/${gridSite.url}` | |||
| gridSite.favicon = `chrome://favicon/size/48@1x/${gridSite.url}` | |||
| gridSite.favicon = `chrome://favicon/size/64@1x/${gridSite.url}` | |||
There was a problem hiding this comment.
What happens here if a 64 pixel version isn't available?
There was a problem hiding this comment.
actually nm - just tried it out; it upscales it 😄
|
Test plan 1 - 👍 Test plan 2
Test plan 3 - code builds great 👍 Test plan 4 - the source icons are showing as 64 pixels, but it's being constrained to 40 pixels Test plan 5 - 👍 |
bsclifton
reviewed
Jan 15, 2019
cezaraugusto
force-pushed
the
ca-newtab-2
branch
from
b1206e5
to
f6b4029
Compare
|
@bsclifton thanks. there was a missing locale for the close button which was addressed. the logic for topsites didn't change so not introduced in this pr. in general top sites will be reworked fully in a new pr |
bsclifton
approved these changes
Jan 15, 2019
|
@cezaraugusto can you please create a PR to uplift this into 0.60.x? I'm getting a fair amount of merge conflicts when doing a cherry-pick |
cezaraugusto
added a commit
that referenced
this pull request
Jan 17, 2019
follow-up of #1339 ref brave/brave-ui@5bafe81
cezaraugusto
pushed a commit
that referenced
this pull request
Jan 17, 2019
refactor ntp to use brave-ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull-request:
Test Plan 1 - change default new tab and private new tab structure
Test Plan 2 - refactor new tab page to use brave-ui
close brave/brave-browser#633
All interactions in new tab top sites should work
Background should change upon browser refresh
Background should load even without internet connection
Links in footer should go to their own links
Test Plan 3 - remove leftover files from ntp
Test Plan 4 - adapt favicon size to 64px to match tile icon size
This is a tentative to make favicons look better without much success, but since favicon image wrapper has 64px I thought to be a good idea to have the same size fetched by Brave
Test Plan 5 - normalize styles using emptykit.css
This bumps the latest
shaversion of brave-ui from @rossmoody and includes only style updates.emptykit.cssis a css normalizer used across our pages but not in new tab, which I included.