Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch onboarding at most once per Solana provider #17241

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Feb 15, 2023

Resolves brave/brave-browser#28546

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

STR in the issue and onboarding should be only shown once.

@darkdh darkdh requested a review from bbondy February 15, 2023 20:54
@darkdh darkdh self-assigned this Feb 15, 2023
@darkdh darkdh requested a review from a team as a code owner February 15, 2023 20:54
@darkdh darkdh merged commit dcf9567 into master Feb 16, 2023
@darkdh darkdh deleted the onboarding-max-1 branch February 16, 2023 20:22
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 16, 2023
darkdh added a commit that referenced this pull request Mar 28, 2023
Launch onboarding at most once per Solana provider
kjozwiak pushed a commit that referenced this pull request Mar 28, 2023
…#17787)

Merge pull request #17241 from brave/onboarding-max-1

Launch onboarding at most once per Solana provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issue with multiple onboarding tabs opening up for Magic Eden
2 participants