Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launch onboarding at most once per Solana provider (uplift to 1.49.x) #17787

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Launch onboarding at most once per Solana provider (uplift to 1.49.x) #17787

merged 1 commit into from
Mar 28, 2023

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Mar 28, 2023 •
edited by kjozwiak
Loading

Uplift of #17241
Resolves brave/brave-browser#28546

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@darkdh
Merge pull request #17241 from brave/onboarding-max-1
14b0a7f 
Launch onboarding at most once per Solana provider
@darkdh darkdh requested a review from a team as a code owner March 28, 2023 01:20
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@kjozwiak kjozwiak added this to the 1.49.x - Release #5 milestone Mar 28, 2023
kjozwiak
kjozwiak approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.49.x approved 👍 QA has verified the PR on Nightly as per brave/brave-browser#28546 (comment).

@kjozwiak kjozwiak merged commit e7584b1 into 1.49.x Mar 28, 2023
@kjozwiak kjozwiak deleted the pr17241_onboarding-max-1_1.49.x branch March 28, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@darkdh darkdh

Labels
None yet
Projects
None yet
Milestone
1.49.x - Release #5
Development

Successfully merging this pull request may close these issues.
2 participants
@darkdh @kjozwiak