-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower severity for DPI and alignment check #17860
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens quite frequently but not that severe when it fails.
fallaciousreasoning
approved these changes
Apr 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @sangwoo108 - good find!
antonok-edm
approved these changes
Apr 1, 2023
25 tasks
Verification
|
Brave | 1.52.25 Chromium: 112.0.5615.49 (Official Build) nightly (64-bit) |
---|---|
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936} |
OS | Windows 10 Version 22H2 (Build 19045.2788) |
First, reproduced original crash using 1.52.2
:
Steps:
- on
Windows 10
, opened theDisplay
control-panel applet - chose
175% / 125%
(see screenshot, above) forScale and layout
/Custom scaling
values - launched Brave
- loaded a few sites
- context-clicked on the tab's title
- chose
Use vertical tabs
Crashed, in (sample incident ID of 2d380200-cefb-e309-0000-000000000000):
[ 00 ] `anonymous namespace'::BraveVerticalTabStyle::GetPath(TabStyle::PathType,float,bool,PathType::RenderUnits) ( brave_tab_style_views.inc.cc:154 )
[ 01 ] _tailMerge_esent.dll
[ 02 ] _tailMerge_esent.dll
[ 03 ] static void `anonymous namespace'::GM2TabStyle::PaintTabBackground(class gfx::Canvas *, TabActive, class absl::optional<int>, int) ( tab_style_views.cc:823 )
[ 04 ] static void * allocator_shim::internal::PartitionMalloc(const struct allocator_shim::AllocatorDispatch *, unsigned __int64, void *) ( allocator_shim_default_dispatch_to_partition_alloc.cc:302 )
[ 05 ] _tailMerge_esent.dll
[ 06 ] ThemeServiceFactory::GetBrowserContextToUse(content::BrowserContext *) ( theme_service_factory.cc:27 )
[ 07 ] _tailMerge_esent.dll
[ 08 ] _tailMerge_esent.dll
[ 09 ] malloc ( allocator_shim_override_ucrt_symbols_win.h:71 )
[ 10 ] Profile::IsTor() ( profile.cc:24 )
[ 11 ] profile_metrics::GetBrowserProfileType(base::SupportsUserData const *) ( browser_profile_type.cc:47 )
[ 12 ] `anonymous namespace'::GM2TabStyle::PaintTab(gfx::Canvas *) ( tab_style_views.cc:515 )
[ 13 ] _tailMerge_esent.dll
[ 14 ] `anonymous namespace'::BraveVerticalTabStyle::PaintTab(gfx::Canvas *) ( brave_tab_style_views.inc.cc:171 )
[ 15 ] views::View::Paint(views::PaintInfo const &) ( view.cc:1243 )
[ 16 ] void GlyphTrackingDevice::~GlyphTrackingDevice() ( SkChromeRemoteGlyphCache.cpp:642 )
[ 17 ] _tailMerge_esent.dll
[ 18 ] _tailMerge_esent.dll
[ 19 ] _tailMerge_esent.dll
[ 20 ] _tailMerge_esent.dll
example | example | example |
---|---|---|
Confirmed FIXED using 1.52.25
:
Steps:
- on
Windows 10
, opened theDisplay
control-panel applet - chose
175% / 125%
(see screenshot, above) forScale and layout
/Custom scaling
values - launched Brave
- loaded a few sites
- context-clicked on the tab's title
- chose
Use vertical tabs
- confirmed no crash
- shut down and relaunched
- confirmed no crash
- drag & dropped tabs
- confirmed no crash
example | example |
---|---|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens quite frequently but not that severe when it fails.
Reportedly, still failed on Linux intermittently
Resolves brave/brave-browser#29398
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: