Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower severity for DPI and alignment check #17860

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Lower severity for DPI and alignment check #17860

merged 1 commit into from
Apr 1, 2023

Conversation

sangwoo108
Copy link
Contributor

@sangwoo108 sangwoo108 commented Mar 31, 2023

This happens quite frequently but not that severe when it fails.
Reportedly, still failed on Linux intermittently

Resolves brave/brave-browser#29398

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This happens quite frequently but not that severe when it fails.
@sangwoo108 sangwoo108 marked this pull request as ready for review March 31, 2023 23:03
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sangwoo108 - good find!

@sangwoo108 sangwoo108 merged commit c2ef75d into master Apr 1, 2023
@sangwoo108 sangwoo108 deleted the sko/vtab-sev branch April 1, 2023 12:03
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Apr 1, 2023
@stephendonner
Copy link
Contributor

stephendonner commented Apr 7, 2023

Verification PASSED using

Brave 1.52.25 Chromium: 112.0.5615.49 (Official Build) nightly (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Windows 10 Version 22H2 (Build 19045.2788)

First, reproduced original crash using 1.52.2:

Steps:

  1. on Windows 10, opened the Display control-panel applet
  2. chose 175% / 125% (see screenshot, above) for Scale and layout / Custom scaling values
  3. launched Brave
  4. loaded a few sites
  5. context-clicked on the tab's title
  6. chose Use vertical tabs

Crashed, in (sample incident ID of 2d380200-cefb-e309-0000-000000000000):

[ 00 ] `anonymous namespace'::BraveVerticalTabStyle::GetPath(TabStyle::PathType,float,bool,PathType::RenderUnits) ( brave_tab_style_views.inc.cc:154 )
[ 01 ] _tailMerge_esent.dll
[ 02 ] _tailMerge_esent.dll
[ 03 ] static void `anonymous namespace'::GM2TabStyle::PaintTabBackground(class gfx::Canvas *, TabActive, class absl::optional<int>, int) ( tab_style_views.cc:823 )
[ 04 ] static void * allocator_shim::internal::PartitionMalloc(const struct allocator_shim::AllocatorDispatch *, unsigned __int64, void *) ( allocator_shim_default_dispatch_to_partition_alloc.cc:302 )
[ 05 ] _tailMerge_esent.dll
[ 06 ] ThemeServiceFactory::GetBrowserContextToUse(content::BrowserContext *) ( theme_service_factory.cc:27 )
[ 07 ] _tailMerge_esent.dll
[ 08 ] _tailMerge_esent.dll
[ 09 ] malloc ( allocator_shim_override_ucrt_symbols_win.h:71 )
[ 10 ] Profile::IsTor() ( profile.cc:24 )
[ 11 ] profile_metrics::GetBrowserProfileType(base::SupportsUserData const *) ( browser_profile_type.cc:47 )
[ 12 ] `anonymous namespace'::GM2TabStyle::PaintTab(gfx::Canvas *) ( tab_style_views.cc:515 )
[ 13 ] _tailMerge_esent.dll
[ 14 ] `anonymous namespace'::BraveVerticalTabStyle::PaintTab(gfx::Canvas *) ( brave_tab_style_views.inc.cc:171 )
[ 15 ] views::View::Paint(views::PaintInfo const &) ( view.cc:1243 )
[ 16 ] void GlyphTrackingDevice::~GlyphTrackingDevice() ( SkChromeRemoteGlyphCache.cpp:642 )
[ 17 ] _tailMerge_esent.dll
[ 18 ] _tailMerge_esent.dll
[ 19 ] _tailMerge_esent.dll
[ 20 ] _tailMerge_esent.dll
example example example
image (1) image image

Confirmed FIXED using 1.52.25:

Steps:

  1. on Windows 10, opened the Display control-panel applet
  2. chose 175% / 125% (see screenshot, above) for Scale and layout / Custom scaling values
  3. launched Brave
  4. loaded a few sites
  5. context-clicked on the tab's title
  6. chose Use vertical tabs
  7. confirmed no crash
  8. shut down and relaunched
  9. confirmed no crash
  10. drag & dropped tabs
  11. confirmed no crash
example example
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical Tabs Crash
4 participants