Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add generated NTP resources in static GRD #936

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

petemill
Copy link
Member

Fix brave/brave-browser#2199

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Fresh build succeeds

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@petemill petemill self-assigned this Nov 20, 2018
@petemill petemill merged commit 838d82d into master Nov 20, 2018
@petemill petemill deleted the fix/resources-not-found branch November 20, 2018 18:35
petemill added a commit to petemill/brave-core that referenced this pull request Nov 27, 2018
Do not add generated NTP resources in static GRD
@petemill
Copy link
Member Author

0.58.x c430fbe

@bbondy
Copy link
Member

bbondy commented Nov 28, 2018

master: 838d82d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fresh builds are failing due to generated web resources in static GRD
4 participants